[PR #485] [MERGED] Oneshot fix #1186

Closed
opened 2026-03-01 14:48:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/485
Author: @cdvv7788
Created: 9/24/2020
Status: Merged
Merged: 9/24/2020
Merged by: @cdvv7788

Base: masterHead: oneshot-fix


📝 Commits (2)

  • f2d950e fix: oneshot command not running extractors
  • 2d8f546 test: Improve oneshot test

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 archivebox/extractors/__init__.py (+1 -1)
📝 tests/test_oneshot.py (+2 -0)

📄 Description

Summary

The oneshot command was not working after some internal list was changed. This PR makes it functional again, and adds a test to prevent it from happening again.

**Related issues: #484

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Archived data layout on disk

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/485 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 9/24/2020 **Status:** ✅ Merged **Merged:** 9/24/2020 **Merged by:** [@cdvv7788](https://github.com/cdvv7788) **Base:** `master` ← **Head:** `oneshot-fix` --- ### 📝 Commits (2) - [`f2d950e`](https://github.com/ArchiveBox/ArchiveBox/commit/f2d950e4e8f89466fa28444b3f5a2120c62f6694) fix: oneshot command not running extractors - [`2d8f546`](https://github.com/ArchiveBox/ArchiveBox/commit/2d8f54682dcd12e5d0ce8d7b3e60f028fedfd7a6) test: Improve oneshot test ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/extractors/__init__.py` (+1 -1) 📝 `tests/test_oneshot.py` (+2 -0) </details> ### 📄 Description # Summary The oneshot command was not working after some internal list was changed. This PR makes it functional again, and adds a test to prevent it from happening again. **Related issues: #484 # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:48:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1186
No description provided.