[PR #446] [MERGED] fix: Issue with timeout in readability #1166

New issue

Closed

opened 2026-03-01 14:48:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/446
Author: @cdvv7788
Created: 8/17/2020
Status: ✅ Merged
Merged: 8/18/2020
Merged by: @pirate

Base: master ← Head: hotfix/#445

📝 Commits (1)

05c71fc fix: Organize readability extractor so a timeout does not break the whole process

📊 Changes

1 file changed (+10 additions, -8 deletions)

View changed files

📝 archivebox/extractors/readability.py (+10 -8)

📄 Description

Summary

download_url was outside of the try/except block, so timeouts were breaking the whole process.

**Related issues: #445

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Archived data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/446 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 8/17/2020 **Status:** ✅ Merged **Merged:** 8/18/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `hotfix/#445` --- ### 📝 Commits (1) - [`05c71fc`](https://github.com/ArchiveBox/ArchiveBox/commit/05c71fc30275e9d555a744efd6745c803a32a8fd) fix: Organize readability extractor so a timeout does not break the whole process ### 📊 Changes **1 file changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/extractors/readability.py` (+10 -8) </details> ### 📄 Description # Summary `download_url` was outside of the `try/except` block, so timeouts were breaking the whole process. **Related issues: #445 # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>