[PR #430] [MERGED] Archivebox not working when using only singlefile extractor #1159

New issue

Closed

opened 2026-03-01 14:48:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/430
Author: @cdvv7788
Created: 8/8/2020
Status: ✅ Merged
Merged: 8/10/2020
Merged by: @pirate

Base: master ← Head: missing-config

📝 Commits (1)

e358634 fix: Add missing configuration that breaks on edge case where only single file is being used

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 archivebox/config/__init__.py (+1 -1)

📄 Description

Summary

github.com/pirate/ArchiveBox@19aa5c3e94 was missing an update to USE_CHROME, so the flag was being set to False which in turn ended up changing SAVE_SINGLEFILE to False too.
This is an edge case, as it only happened when no dom, picture or pdf was being saved.

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Archived data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/430 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 8/8/2020 **Status:** ✅ Merged **Merged:** 8/10/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `missing-config` --- ### 📝 Commits (1) - [`e358634`](https://github.com/ArchiveBox/ArchiveBox/commit/e358634f812f0832c7adaf231eae559c653aa8a6) fix: Add missing configuration that breaks on edge case where only single file is being used ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/config/__init__.py` (+1 -1) </details> ### 📄 Description # Summary https://github.com/pirate/ArchiveBox/commit/19aa5c3e94118c495a21ea291d56608cc96ccf47 was missing an update to `USE_CHROME`, so the flag was being set to `False` which in turn ended up changing `SAVE_SINGLEFILE` to `False` too. This is an edge case, as it only happened when no `dom`, `picture` or `pdf` was being saved. # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>