[PR #394] [MERGED] Delete isolated quote in ArchiveBox.conf.default #1152

Closed
opened 2026-03-01 14:48:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/394
Author: @imlonghao
Created: 7/29/2020
Status: Merged
Merged: 7/29/2020
Merged by: @pirate

Base: masterHead: patch-1


📝 Commits (1)

  • d9348ec Delete isolated quote in ArchiveBox.conf.default

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 etc/ArchiveBox.conf.default (+1 -1)

📄 Description

IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes, I will close them with great prejudice. The PEP8 checks I don't follow are intentional. PRs for minor bugfixes, typos, etc are fine.

Summary

There is an isolated quote introduce in commit github.com/pirate/ArchiveBox@4d6ad7a65d (diff-a0d96f90b2)

This PR just simply delete the quote.

- #GIT_BINARY="git"
+ # GIT_BINARY = git"

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Archived data layout on disk

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/394 **Author:** [@imlonghao](https://github.com/imlonghao) **Created:** 7/29/2020 **Status:** ✅ Merged **Merged:** 7/29/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`d9348ec`](https://github.com/ArchiveBox/ArchiveBox/commit/d9348ec82b9c46998bfa67fcd6b259f3d3e807a1) Delete isolated quote in ArchiveBox.conf.default ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `etc/ArchiveBox.conf.default` (+1 -1) </details> ### 📄 Description **IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes, I will close them with great prejudice. The PEP8 checks I don't follow are intentional. PRs for minor bugfixes, typos, etc are fine.** # Summary There is an isolated quote introduce in commit https://github.com/pirate/ArchiveBox/commit/4d6ad7a65dc014a2ed4429401f11c4f8ec6305c1#diff-a0d96f90b24495fbbd701cfc0d94b192R53 This PR just simply delete the quote. ```diff - #GIT_BINARY="git" + # GIT_BINARY = git" ``` # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:48:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1152
No description provided.