[PR #379] [MERGED] #372 Rename logging module to avoid conflicts #1138

New issue

Closed

opened 2026-03-01 14:48:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/379
Author: @cdvv7788
Created: 7/22/2020
Status: ✅ Merged
Merged: 7/22/2020
Merged by: @pirate

Base: django ← Head: hotfix/#372-b

📝 Commits (1)

a5550b2 fix: Rename logging folder to avoid naming conflicts (and circular import issues)

📊 Changes

29 files changed (+28 additions, -28 deletions)

View changed files

📝 archivebox/cli/__init__.py (+1 -1)
📝 archivebox/cli/archivebox_add.py (+1 -1)
📝 archivebox/cli/archivebox_config.py (+1 -1)
📝 archivebox/cli/archivebox_help.py (+1 -1)
📝 archivebox/cli/archivebox_init.py (+1 -1)
📝 archivebox/cli/archivebox_list.py (+1 -1)
📝 archivebox/cli/archivebox_remove.py (+1 -1)
📝 archivebox/cli/archivebox_schedule.py (+1 -1)
📝 archivebox/cli/archivebox_server.py (+1 -1)
📝 archivebox/cli/archivebox_shell.py (+1 -1)
📝 archivebox/cli/archivebox_status.py (+1 -1)
📝 archivebox/cli/archivebox_update.py (+1 -1)
📝 archivebox/cli/archivebox_version.py (+1 -1)
📝 archivebox/core/admin.py (+1 -1)
📝 archivebox/core/welcome_message.py (+1 -1)
📝 archivebox/extractors/__init__.py (+1 -1)
📝 archivebox/extractors/archive_org.py (+1 -1)
📝 archivebox/extractors/dom.py (+1 -1)
📝 archivebox/extractors/favicon.py (+1 -1)
📝 archivebox/extractors/git.py (+1 -1)

...and 9 more files

📄 Description

Summary

The logging module was causing issues when imported from external libraries because of a naming conflict with the standard python library

**Related issues: #372

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Archived data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/379 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 7/22/2020 **Status:** ✅ Merged **Merged:** 7/22/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `django` ← **Head:** `hotfix/#372-b` --- ### 📝 Commits (1) - [`a5550b2`](https://github.com/ArchiveBox/ArchiveBox/commit/a5550b21051e89478318702b566355fe34b029c3) fix: Rename logging folder to avoid naming conflicts (and circular import issues) ### 📊 Changes **29 files changed** (+28 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/cli/__init__.py` (+1 -1) 📝 `archivebox/cli/archivebox_add.py` (+1 -1) 📝 `archivebox/cli/archivebox_config.py` (+1 -1) 📝 `archivebox/cli/archivebox_help.py` (+1 -1) 📝 `archivebox/cli/archivebox_init.py` (+1 -1) 📝 `archivebox/cli/archivebox_list.py` (+1 -1) 📝 `archivebox/cli/archivebox_remove.py` (+1 -1) 📝 `archivebox/cli/archivebox_schedule.py` (+1 -1) 📝 `archivebox/cli/archivebox_server.py` (+1 -1) 📝 `archivebox/cli/archivebox_shell.py` (+1 -1) 📝 `archivebox/cli/archivebox_status.py` (+1 -1) 📝 `archivebox/cli/archivebox_update.py` (+1 -1) 📝 `archivebox/cli/archivebox_version.py` (+1 -1) 📝 `archivebox/core/admin.py` (+1 -1) 📝 `archivebox/core/welcome_message.py` (+1 -1) 📝 `archivebox/extractors/__init__.py` (+1 -1) 📝 `archivebox/extractors/archive_org.py` (+1 -1) 📝 `archivebox/extractors/dom.py` (+1 -1) 📝 `archivebox/extractors/favicon.py` (+1 -1) 📝 `archivebox/extractors/git.py` (+1 -1) _...and 9 more files_ </details> ### 📄 Description # Summary The `logging` module was causing issues when imported from external libraries because of a naming conflict with the standard python library **Related issues: #372 # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>