[PR #358] [CLOSED] Django public views #1123

Closed
opened 2026-03-01 14:48:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/358
Author: @cdvv7788
Created: 7/8/2020
Status: Closed

Base: djangoHead: public-view


📝 Commits (1)

  • 63847c2 fix: Add LoginRequiredMixin to django views

📊 Changes

1 file changed (+4 additions, -5 deletions)

View changed files

📝 archivebox/core/views.py (+4 -5)

📄 Description

Summary

Currently, all of the views in django (outside of the admin) are public. I am not sure if that is intended.
I added the LoginRequiredMixin to all of them.
If they are meant to be public, just close the PR.

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Archived data layout on disk

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/358 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 7/8/2020 **Status:** ❌ Closed **Base:** `django` ← **Head:** `public-view` --- ### 📝 Commits (1) - [`63847c2`](https://github.com/ArchiveBox/ArchiveBox/commit/63847c2b1d9d103933bf6b19a61c6baa6f33951b) fix: Add LoginRequiredMixin to django views ### 📊 Changes **1 file changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/core/views.py` (+4 -5) </details> ### 📄 Description # Summary Currently, all of the views in django (outside of the admin) are public. I am not sure if that is intended. I added the `LoginRequiredMixin` to all of them. If they are meant to be public, just close the PR. # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:48:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1123
No description provided.