[PR #217] [CLOSED] Archive Method: Add Firefox for full page screenshots #1098

Closed
opened 2026-03-01 14:48:25 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/217
Author: @pheki
Created: 4/16/2019
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • 1d85231 Adds firefox support for full page screenshots

📊 Changes

3 files changed (+110 additions, -23 deletions)

View changed files

📝 archivebox/archive_methods.py (+16 -6)
📝 archivebox/config.py (+75 -17)
📝 archivebox/util.py (+19 -0)

📄 Description

Summary

This PRs adds firefox support for full page screenshots! Firefox has the advantage of taking the screenshots of the whole page, independent of the viewport size.

Related issues: #70, #80, #14

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Archived data layout on disk

Unfortunately, the user must make the profile to be used manually, either with firefox --createProfile ArchiveBox or by going to about:profiles and selecting "Create a New Profile". A separate profile is needed because firefox doesn't allow the default instance to be opened in the same profile at the same time as the headless instance. Creating a profile could be automated, but the proccess involves reading profiles.ini (and well, modifying user profiles) which I'm not sure is at the scope of this project.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/217 **Author:** [@pheki](https://github.com/pheki) **Created:** 4/16/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`1d85231`](https://github.com/ArchiveBox/ArchiveBox/commit/1d85231a93607618501b79fdebcc37e225a885cd) Adds firefox support for full page screenshots ### 📊 Changes **3 files changed** (+110 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/archive_methods.py` (+16 -6) 📝 `archivebox/config.py` (+75 -17) 📝 `archivebox/util.py` (+19 -0) </details> ### 📄 Description # Summary This PRs adds firefox support for full page screenshots! Firefox has the advantage of taking the screenshots of the whole page, independent of the viewport size. **Related issues: #70, #80, #14** # Changes these areas - [ ] Bugfixes - [x] Feature behavior - [ ] Command line interface - [X] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk Unfortunately, the user must make the profile to be used manually, either with `firefox --createProfile ArchiveBox` or by going to about:profiles and selecting "Create a New Profile". A separate profile is needed because firefox doesn't allow the default instance to be opened in the same profile at the same time as the headless instance. Creating a profile could be automated, but the proccess involves reading profiles.ini (and well, modifying user profiles) which I'm not sure is at the scope of this project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:48:25 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1098
No description provided.