mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #217] [CLOSED] Archive Method: Add Firefox for full page screenshots #1098
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1098
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/217
Author: @pheki
Created: 4/16/2019
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
1d85231Adds firefox support for full page screenshots📊 Changes
3 files changed (+110 additions, -23 deletions)
View changed files
📝
archivebox/archive_methods.py(+16 -6)📝
archivebox/config.py(+75 -17)📝
archivebox/util.py(+19 -0)📄 Description
Summary
This PRs adds firefox support for full page screenshots! Firefox has the advantage of taking the screenshots of the whole page, independent of the viewport size.
Related issues: #70, #80, #14
Changes these areas
Unfortunately, the user must make the profile to be used manually, either with
firefox --createProfile ArchiveBoxor by going to about:profiles and selecting "Create a New Profile". A separate profile is needed because firefox doesn't allow the default instance to be opened in the same profile at the same time as the headless instance. Creating a profile could be automated, but the proccess involves reading profiles.ini (and well, modifying user profiles) which I'm not sure is at the scope of this project.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.