[PR #147] [MERGED] Don't run ls if using non-default directory #1077

New issue

Closed

opened 2026-03-01 14:48:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/147
Author: @nicolaschan
Created: 2/19/2019
Status: ✅ Merged
Merged: 2/19/2019
Merged by: @pirate

Base: master ← Head: patch-1

📝 Commits (1)

c834b2e Don't run ls if using non-default directory

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 bin/archivebox-export-browser-history (+2 -2)

📄 Description

Previously, an error message would appear if using a non-default directory because it would run ls on the non-existent default directory:

ls: cannot access '/home/nicolas/Library/Application Support/Firefox/Profiles/*.default/places.sqlite': No such file or directory

Summary

This PR fixes an error message that appears when exporting browser history from a non-default directory (such as on Ubuntu, where Firefox data is at ~/.mozilla/firefox/).

Changes these areas

Config
Bugfixes
Command line interface
Feature behavior
Internal design
Archived data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/147 **Author:** [@nicolaschan](https://github.com/nicolaschan) **Created:** 2/19/2019 **Status:** ✅ Merged **Merged:** 2/19/2019 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`c834b2e`](https://github.com/ArchiveBox/ArchiveBox/commit/c834b2ef133a0fb3b6a9a44f30f5df1836082456) Don't run ls if using non-default directory ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bin/archivebox-export-browser-history` (+2 -2) </details> ### 📄 Description Previously, an error message would appear if using a non-default directory because it would run `ls` on the non-existent default directory: ```bash ls: cannot access '/home/nicolas/Library/Application Support/Firefox/Profiles/*.default/places.sqlite': No such file or directory ``` # Summary This PR fixes an error message that appears when exporting browser history from a non-default directory (such as on Ubuntu, where Firefox data is at `~/.mozilla/firefox/`). # Changes these areas - [ ] Config - [x] Bugfixes - [ ] Command line interface - [ ] Feature behavior - [ ] Internal design - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>