[PR #142] [CLOSED] return url instead of title if it contains a < #1072

Closed
opened 2026-03-01 14:48:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/142
Author: @Strubbl
Created: 2/14/2019
Status: Closed

Base: masterHead: fix-title-detection


📝 Commits (1)

  • 13d7969 return url instead of title if it contains a <

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 archivebox/util.py (+1 -1)

📄 Description

The method fetch_page_title does not return the found title, if that
title contains a left angle bracket. This bracket usually indicates
that an opening tag follows, which we do not want in out title since it
breaks the table in the index.html.

fixes #141

Summary

This PR changes fetch_page_title to return the url instead of title if title contains a left angle bracket

Changes these areas

  • Config
  • Bugfixes
  • Command line interface
  • Feature behavior
  • Internal design
  • Archived data layout on disk

Roadmap Goals

This PR helps us move towards ??? roadmap goal, as outlined here: https://github.com/pirate/ArchiveBox#roadmap
--> roadmap link does not work


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/142 **Author:** [@Strubbl](https://github.com/Strubbl) **Created:** 2/14/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-title-detection` --- ### 📝 Commits (1) - [`13d7969`](https://github.com/ArchiveBox/ArchiveBox/commit/13d7969e6a490f34db19abcd1bdadec58925c30e) return url instead of title if it contains a < ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/util.py` (+1 -1) </details> ### 📄 Description The method fetch_page_title does not return the found title, if that title contains a left angle bracket. This bracket usually indicates that an opening tag follows, which we do not want in out title since it breaks the table in the index.html. fixes #141 # Summary This PR changes fetch_page_title to return the url instead of title if title contains a left angle bracket # Changes these areas - [ ] Config - [x] Bugfixes - [ ] Command line interface - [ ] Feature behavior - [ ] Internal design - [ ] Archived data layout on disk # Roadmap Goals This PR helps us move towards ??? roadmap goal, as outlined here: https://github.com/pirate/ArchiveBox#roadmap --> roadmap link does not work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:48:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1072
No description provided.