mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #155] Double-download of Chromium binary and broken symlinks in Dockerfile #107
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#107
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @raman325 on GitHub (Mar 2, 2019).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/155
Describe the bug
When I attempt to run docker-compose as recommended, the puppeteer installation step fails. From https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-in-docker I see a section that says:
Is it possible that should be included in the Dockerfile run (including using the new launch command) since we are downloading google-chrome-unstable anyway?
Steps to reproduce
Steps to reproduce the behavior:
docker-compose up -dScreenshots or log output
Software versions (please complete the following information):
63e6ed8)@raman325 commented on GitHub (Mar 2, 2019):
Created PR #156 with this change and another one which got my container up and running.
Also, just a suggestion, you should consider adding
--remove-orphansas an argument to your docker-compose command on your Docker page. An extra container ends up getting created as part of the process that is orphaned and is stopped - just uses up extra space. Final command under https://github.com/pirate/ArchiveBox/wiki/Docker#setup would bedocker-compose up -d --remove-orphansif you agree. I tested it and it appears to be safe.@raman325 commented on GitHub (Mar 2, 2019):
Also noticed on your Wiki page for Docker, you reference/bin/archivein multiple places which doesn't exist. Should that be/bin/archiveboxinstead?EDIT: this comment is irrelevant given @pirate's comments on my PR