[PR #58] [CLOSED] Add a parser for a list of links (see issue #39): #1047

New issue

Closed

opened 2026-03-01 14:48:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/58
Author: @frinkelpi
Created: 12/25/2017
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

278ecfe Add a parser for a list of links (see issue #39):

📊 Changes

13 files changed (+161 additions, -135 deletions)

View changed files

📝 README.md (+33 -38)
📝 archive.py (+7 -7)
📝 archive_methods.py (+28 -7)
📝 config.py (+2 -1)
📝 index.py (+4 -1)
📝 parse.py (+34 -43)
➕ requirements.txt (+1 -0)
📝 setup.sh (+3 -1)
📝 templates/index.html (+2 -2)
📝 templates/index_row.html (+2 -1)
📝 templates/link_index.html (+1 -0)
📝 templates/link_index_fancy.html (+1 -0)
📝 util.py (+43 -34)

📄 Description

basic_link_info method in parse.py to avoid code duplication.
Fetch method to get missing titles.
Fix some HTML syntax errors in the templates.
Simpler version of html_appended_url in utils.py using urlsplit.
Update the README accordingly. Remove some repetition and minor style improvements.
Add instructions to install requests (which was already used in utils.py). Add requirements.txt.
Fix a bug where a KeyError would be thrown when generating the templates if screenshots or PDFs are disabled.
If FETCH_WGET_REQUISITES is disabled, then wget stores the output in a different way, which was not handled and resulted in bugs. This has been corrected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/58 **Author:** [@frinkelpi](https://github.com/frinkelpi) **Created:** 12/25/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`278ecfe`](https://github.com/ArchiveBox/ArchiveBox/commit/278ecfe7ec8c934931f1252ae0bcaccbb752b5bb) Add a parser for a list of links (see issue #39): ### 📊 Changes **13 files changed** (+161 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+33 -38) 📝 `archive.py` (+7 -7) 📝 `archive_methods.py` (+28 -7) 📝 `config.py` (+2 -1) 📝 `index.py` (+4 -1) 📝 `parse.py` (+34 -43) ➕ `requirements.txt` (+1 -0) 📝 `setup.sh` (+3 -1) 📝 `templates/index.html` (+2 -2) 📝 `templates/index_row.html` (+2 -1) 📝 `templates/link_index.html` (+1 -0) 📝 `templates/link_index_fancy.html` (+1 -0) 📝 `util.py` (+43 -34) </details> ### 📄 Description - `basic_link_info` method in parse.py to avoid code duplication. - Fetch method to get missing titles. - Fix some HTML syntax errors in the templates. - Simpler version of `html_appended_url` in utils.py using urlsplit. - Update the README accordingly. Remove some repetition and minor style improvements. - Add instructions to install requests (which was already used in utils.py). Add requirements.txt. - Fix a bug where a KeyError would be thrown when generating the templates if screenshots or PDFs are disabled. - If FETCH_WGET_REQUISITES is disabled, then wget stores the output in a different way, which was not handled and resulted in bugs. This has been corrected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 14:48:13 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#1047

No description provided.

Rows
Columns