[GH-ISSUE #319] Parity: Review submissions and submission items #93

New issue

Closed

opened 2026-02-26 21:33:19 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 21:33:19 +03:00

Owner

Copy link

Originally created by @rudrankriyam on GitHub (Jan 30, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/319

Overview

Expose remaining review submission endpoints: submission item CRUD and submission updates, plus relationship-only endpoints where useful. Keep JSON-first output and explicit flags.

Scope (OpenAPI resources)

reviewSubmissionItems GET/PATCH by ID
reviewSubmissions PATCH by ID
Relationship endpoints for submission items (IDs-only)

Proposed CLI

Top-level group:

asc review ...

New/expanded subcommands:

review items get --id ITEM_ID
review items update --id ITEM_ID --state READY_FOR_REVIEW|IN_REVIEW|...
review submissions update --id SUBMISSION_ID --canceled true|false
review submissions items-ids --id SUBMISSION_ID (optional IDs-only)

Examples:

asc review items get --id ITEM_ID
asc review items update --id ITEM_ID --state READY_FOR_REVIEW
asc review submissions update --id SUBMISSION_ID --canceled true

Flag patterns

Common:

--id, --output, --pretty, --confirm

Resource-specific:

--state, --canceled

Output

JSON minified by default
--pretty for JSON
--output table/markdown for list commands

Detailed TODO

Add client method for GET /v1/reviewSubmissionItems/{id}
Add client method for PATCH /v1/reviewSubmissionItems/{id}
Expose existing submission update method via CLI
(Optional) Add relationship IDs endpoint for submission items
Implement CLI commands for items get/update
Implement CLI command for submission update
Add cmdtests + HTTP client tests (mocked)

Acceptance criteria

asc review items get returns item details
asc review items update updates state
asc review submissions update updates submission attributes
JSON-first output preserved
Validation errors are clear and consistent

Tests

Flag validation tests
HTTP client tests for get/update
Output tests for json/table/markdown where applicable

Implementation notes

Add/update methods in internal/asc/client_reviews.go
Add CLI commands in internal/cli/reviews
Follow patterns in existing review submissions commands

Originally created by @rudrankriyam on GitHub (Jan 30, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/319 # Overview Expose remaining review submission endpoints: submission item CRUD and submission updates, plus relationship-only endpoints where useful. Keep JSON-first output and explicit flags. # Scope (OpenAPI resources) - `reviewSubmissionItems` GET/PATCH by ID - `reviewSubmissions` PATCH by ID - Relationship endpoints for submission items (IDs-only) # Proposed CLI Top-level group: - `asc review ...` New/expanded subcommands: - `review items get --id ITEM_ID` - `review items update --id ITEM_ID --state READY_FOR_REVIEW|IN_REVIEW|...` - `review submissions update --id SUBMISSION_ID --canceled true|false` - `review submissions items-ids --id SUBMISSION_ID` (optional IDs-only) Examples: - `asc review items get --id ITEM_ID` - `asc review items update --id ITEM_ID --state READY_FOR_REVIEW` - `asc review submissions update --id SUBMISSION_ID --canceled true` # Flag patterns Common: - `--id`, `--output`, `--pretty`, `--confirm` Resource-specific: - `--state`, `--canceled` # Output - JSON minified by default - `--pretty` for JSON - `--output table/markdown` for list commands # Detailed TODO - [ ] Add client method for `GET /v1/reviewSubmissionItems/{id}` - [ ] Add client method for `PATCH /v1/reviewSubmissionItems/{id}` - [ ] Expose existing submission update method via CLI - [ ] (Optional) Add relationship IDs endpoint for submission items - [ ] Implement CLI commands for items get/update - [ ] Implement CLI command for submission update - [ ] Add cmdtests + HTTP client tests (mocked) # Acceptance criteria - [ ] `asc review items get` returns item details - [ ] `asc review items update` updates state - [ ] `asc review submissions update` updates submission attributes - [ ] JSON-first output preserved - [ ] Validation errors are clear and consistent # Tests - Flag validation tests - HTTP client tests for get/update - Output tests for json/table/markdown where applicable # Implementation notes - Add/update methods in `internal/asc/client_reviews.go` - Add CLI commands in `internal/cli/reviews` - Follow patterns in existing `review submissions` commands

kerem closed this issue

2026-02-26 21:33:19 +03:00

kerem commented

2026-02-26 21:33:20 +03:00

Author

Owner

Copy link

@rudrankriyam commented on GitHub (Jan 30, 2026):

@cursor Please implement per issue description. No live credentials; use mocked tests. Run make build/lint/test and open a PR when green. Keep JSON-first output and explicit flags; no interactive prompts.

@rudrankriyam commented on GitHub (Jan 30, 2026): @cursor Please implement per issue description. No live credentials; use mocked tests. Run make build/lint/test and open a PR when green. Keep JSON-first output and explicit flags; no interactive prompts.

kerem commented

2026-02-26 21:33:20 +03:00

Author

Owner

Copy link

@cursor[bot] commented on GitHub (Jan 30, 2026):

Summary:

I added client support for review submission item GET/PATCH and submission item relationship IDs, plus new asc review commands for items-get, items-update --state, submissions-update --canceled, and submissions-items-ids, and updated help/examples accordingly.
I added mocked tests for the new client methods, CLI flag validation for the new commands, and table/markdown output coverage for review submissions/items.

Tests run (all green): make build, make lint, make test.

I pushed the changes to cursor/review-items-and-submissions-14ff. I can’t open a PR directly in this environment, but GitHub provided this link to open one: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/new/cursor/review-items-and-submissions-14ff.

@cursor[bot] commented on GitHub (Jan 30, 2026): Summary: - I added client support for review submission item GET/PATCH and submission item relationship IDs, plus new `asc review` commands for `items-get`, `items-update --state`, `submissions-update --canceled`, and `submissions-items-ids`, and updated help/examples accordingly. - I added mocked tests for the new client methods, CLI flag validation for the new commands, and table/markdown output coverage for review submissions/items. Tests run (all green): `make build`, `make lint`, `make test`. I pushed the changes to `cursor/review-items-and-submissions-14ff`. I can’t open a PR directly in this environment, but GitHub provided this link to open one: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/new/cursor/review-items-and-submissions-14ff. <a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/333"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-22229d67-0639-4c24-87d7-474a54e2ec8d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-22229d67-0639-4c24-87d7-474a54e2ec8d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>

kerem commented

2026-02-26 21:33:20 +03:00

Author

Owner

Copy link

@rudrankriyam commented on GitHub (Jan 30, 2026):

Fixed by #333. Included in release 0.20.2.

@rudrankriyam commented on GitHub (Jan 30, 2026): Fixed by #333. Included in release 0.20.2.

kerem referenced this issue

2026-02-26 21:34:24 +03:00

[PR #91] [MERGED] Add builds latest command #276

kerem referenced this issue

2026-02-26 21:34:24 +03:00

[PR #93] [MERGED] Version filter platform limit #277

No Branch/Tag specified

main

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.49.1

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.2

0.46.1

0.46.0

0.45.4

0.45.3

0.45.2

0.45.1

0.45.0

0.44.2

0.44.1

0.44.0

0.43.0

0.42.0

0.41.4

0.41.3

0.41.2

0.41.1

0.41.0

0.40.1

0.40.0

0.39.1

0.39.0

0.38.3

0.38.2

0.38.1

0.38.0

0.37.3

0.37.2

0.37.1

0.37.0

0.36.3

0.36.2

0.36.1

0.36.0

0.35.3

0.35.2

0.35.1

0.35.0

0.34.1

0.34.0

0.33.2

0.33.1

0.33.0

0.32.0

0.31.3

0.31.2

0.31.1

0.31.0

0.30.0

0.29.3

0.29.2

0.29.1

0.29.0

0.28.14

0.28.13

0.28.12

0.28.11

0.28.10

0.28.9

0.28.8

0.28.7

0.28.6

0.28.5

0.28.4

0.28.3

0.28.2

0.28.1

0.28.0

0.27.0

0.26.4

0.26.3

0.26.2

0.26.1

0.26.0

0.25.4

0.25.3

0.25.1

0.25.0

0.24.3

0.24.2

0.24.1

0.24.0

0.23.5

0.23.4

0.23.3

0.23.2

0.23.1

0.23.0

0.22.1

0.22.0

0.21.0

0.20.2

0.20.1

0.20.0

0.19.3

0.19.2

0.19.1

0.19.0

0.18.2

0.18.1

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.0

0.10.2

0.10.1

0.10.0

0.9.0

0.8.1

0.8.0

0.7.0

0.6.0

0.5.0

0.3.1

0.3.0

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/App-Store-Connect-CLI#93

Reference in a new issue

Repository

starred/App-Store-Connect-CLI

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns