[PR #792] [MERGED] fix(web-apps): ensure bundle IDs exist before web app creation #790

New issue

Closed

opened 2026-02-26 22:32:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/792
Author: @rudrankriyam
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/web-apps-bundle-id-preflight

📝 Commits (1)

3a1b1ec fix(web-apps): ensure bundle IDs exist before web app creation

📊 Changes

2 files changed (+194 additions, -3 deletions)

View changed files

📝 internal/cli/web/web_apps.go (+78 -3)
📝 internal/cli/web/web_apps_test.go (+116 -0)

📄 Description

Summary

add a bundle ID preflight step to asc web apps create that checks for the identifier and creates it automatically when missing
use the existing ASC API client for bundle ID lookup/create (instead of the unsupported web endpoint) and handle duplicate races safely
add command tests to verify preflight ordering and failure propagation before app creation

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test
go test ./internal/cli/web ./internal/cli/cmdtest -run Web
Live smoke: go run . web apps create --name "ASC Smoke 20260226211209" --bundle-id "com.rudrank.ascsmoke.20260226211209" --sku "SMOKE20260226211209" --apple-id "boo@gmail.com" --output json

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/792 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/web-apps-bundle-id-preflight` --- ### 📝 Commits (1) - [`3a1b1ec`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3a1b1ec9161e33776c2345799d07ab48c81350ac) fix(web-apps): ensure bundle IDs exist before web app creation ### 📊 Changes **2 files changed** (+194 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/web/web_apps.go` (+78 -3) 📝 `internal/cli/web/web_apps_test.go` (+116 -0) </details> ### 📄 Description ## Summary - add a bundle ID preflight step to `asc web apps create` that checks for the identifier and creates it automatically when missing - use the existing ASC API client for bundle ID lookup/create (instead of the unsupported web endpoint) and handle duplicate races safely - add command tests to verify preflight ordering and failure propagation before app creation ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` - [x] `go test ./internal/cli/web ./internal/cli/cmdtest -run Web` - [x] Live smoke: `go run . web apps create --name "ASC Smoke 20260226211209" --bundle-id "com.rudrank.ascsmoke.20260226211209" --sku "SMOKE20260226211209" --apple-id "boo@gmail.com" --output json` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>