[PR #789] [MERGED] fix(web): add interactive password prompt fallback for web auth #788

New issue

Closed

opened 2026-02-26 22:32:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/789
Author: @rudrankriyam
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/web-auth-interactive-password-prompt

📝 Commits (3)

f1b9598 fix(web): prompt for password in interactive web auth
50ebc81 fix(web): make interactive password flow the default path
937ec1b fix(web-apps): avoid password prompt before cache lookup

📊 Changes

5 files changed (+254 additions, -23 deletions)

View changed files

📝 internal/cli/web/web_apps.go (+4 -8)
➕ internal/cli/web/web_apps_test.go (+61 -0)
📝 internal/cli/web/web_auth.go (+47 -9)
📝 internal/cli/web/web_auth_test.go (+140 -0)
📝 internal/cli/web/web_session_flags.go (+2 -6)

📄 Description

Summary

add a secure interactive password prompt fallback for asc web auth login and web-session-backed commands when --password-stdin and ASC_WEB_PASSWORD are both absent
preserve non-interactive behavior: automation still uses --password-stdin or ASC_WEB_PASSWORD, and missing non-TTY input still returns the existing usage error
update help text/examples and add focused tests for stdin/env/prompt password-source resolution and terminal read failures

Test plan

ASC_BYPASS_KEYCHAIN=1 go test ./internal/cli/web ./internal/cli/cmdtest
make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/789 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/web-auth-interactive-password-prompt` --- ### 📝 Commits (3) - [`f1b9598`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f1b95984edab973a02fbb63d15abfe9977d388ea) fix(web): prompt for password in interactive web auth - [`50ebc81`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/50ebc81025789b6965c3ebc0ca58d645d9501930) fix(web): make interactive password flow the default path - [`937ec1b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/937ec1bab3c15f7ca4119130e84eb516a695e05f) fix(web-apps): avoid password prompt before cache lookup ### 📊 Changes **5 files changed** (+254 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/web/web_apps.go` (+4 -8) ➕ `internal/cli/web/web_apps_test.go` (+61 -0) 📝 `internal/cli/web/web_auth.go` (+47 -9) 📝 `internal/cli/web/web_auth_test.go` (+140 -0) 📝 `internal/cli/web/web_session_flags.go` (+2 -6) </details> ### 📄 Description ## Summary - add a secure interactive password prompt fallback for `asc web auth login` and web-session-backed commands when `--password-stdin` and `ASC_WEB_PASSWORD` are both absent - preserve non-interactive behavior: automation still uses `--password-stdin` or `ASC_WEB_PASSWORD`, and missing non-TTY input still returns the existing usage error - update help text/examples and add focused tests for stdin/env/prompt password-source resolution and terminal read failures ## Test plan - [x] `ASC_BYPASS_KEYCHAIN=1 go test ./internal/cli/web ./internal/cli/cmdtest` - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>