[PR #780] [CLOSED] Web review command issues #781

New issue

Closed

opened 2026-02-26 22:32:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/780
Author: @cursor[bot]
Created: 2/25/2026
Status: ❌ Closed

Base: feat/web-review-resolution ← Head: cursor/web-review-command-issues-ca17

📝 Commits (1)

7450c79 Fix web review show path sanitization and duplicate thread fetches

📊 Changes

4 files changed (+228 additions, -72 deletions)

View changed files

📝 internal/cli/web/web_review.go (+22 -17)
📝 internal/cli/web/web_review_test.go (+9 -0)
📝 internal/web/review.go (+115 -55)
📝 internal/web/review_workflows_test.go (+82 -0)

📄 Description

Summary

Fixed a path traversal vulnerability in sanitizePathPart by neutralizing .. to prevent directory escape.
Optimized WebReviewShowCommand to avoid duplicate API calls for fetching thread messages, rejections, and attachments, significantly reducing command execution time.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/780 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `feat/web-review-resolution` ← **Head:** `cursor/web-review-command-issues-ca17` --- ### 📝 Commits (1) - [`7450c79`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7450c7966064136b6daa8e83ea8142058a8351d6) Fix web review show path sanitization and duplicate thread fetches ### 📊 Changes **4 files changed** (+228 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/web/web_review.go` (+22 -17) 📝 `internal/cli/web/web_review_test.go` (+9 -0) 📝 `internal/web/review.go` (+115 -55) 📝 `internal/web/review_workflows_test.go` (+82 -0) </details> ### 📄 Description ## Summary - Fixed a path traversal vulnerability in `sanitizePathPart` by neutralizing `..` to prevent directory escape. - Optimized `WebReviewShowCommand` to avoid duplicate API calls for fetching thread messages, rejections, and attachments, significantly reducing command execution time. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>