[PR #773] [MERGED] Upload timeout hint value #777

New issue

Closed

opened 2026-02-26 22:32:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/773
Author: @cursor[bot]
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @rudrankriyam

Base: cursor/app-store-experiment-treatment-localizations-9894 ← Head: cursor/upload-timeout-hint-value-aefa

📝 Commits (1)

51af4fe fix: raise upload timeout hint above new default

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 internal/cli/shared/errfmt/errfmt.go (+1 -1)
📝 internal/cli/shared/errfmt/errfmt_test.go (+1 -1)

📄 Description

Summary

Updated the uploadTimeoutHint from 300s to 600s to provide a meaningful increase over the DefaultUploadTimeout (which is now 300s), aligning with the pattern used for requestTimeoutHint.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/773 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/app-store-experiment-treatment-localizations-9894` ← **Head:** `cursor/upload-timeout-hint-value-aefa` --- ### 📝 Commits (1) - [`51af4fe`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/51af4fe542c714d9ef0a59b4ded6b9d4db2e5bc6) fix: raise upload timeout hint above new default ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/shared/errfmt/errfmt.go` (+1 -1) 📝 `internal/cli/shared/errfmt/errfmt_test.go` (+1 -1) </details> ### 📄 Description ## Summary - Updated the `uploadTimeoutHint` from `300s` to `600s` to provide a meaningful increase over the `DefaultUploadTimeout` (which is now `300s`), aligning with the pattern used for `requestTimeoutHint`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>