[PR #747] [CLOSED] Screenshot dimension validation #759

New issue

Closed

opened 2026-02-26 22:32:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/747
Author: @cursor[bot]
Created: 2/23/2026
Status: ❌ Closed

Base: cursor/asc-screenshot-dimensions-5f95 ← Head: cursor/screenshot-dimension-validation-8e7d

📝 Commits (1)

00408c3 Fix screenshot dimension validation for iPhone 6.9 alias

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 internal/cli/assets/assets_screenshots.go (+1 -1)
📝 internal/cli/cmdtest/assets_screenshots_sizes_test.go (+3 -3)

📄 Description

Summary

Fixes a bug where screenshot dimension validation incorrectly used the canonical API display type (APP_IPHONE_67) instead of the original user-specified type (APP_IPHONE_69), leading to rejection of valid 1284x2778 dimensions.
Ensures validation uses the full set of dimensions for the user's specified device type, while the API call continues to use the canonical type.
Adds a new test case to specifically validate IPHONE_69 with 1284x2778 dimensions.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/747 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/23/2026 **Status:** ❌ Closed **Base:** `cursor/asc-screenshot-dimensions-5f95` ← **Head:** `cursor/screenshot-dimension-validation-8e7d` --- ### 📝 Commits (1) - [`00408c3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/00408c3d2c69eadbe5b0a99f517d82bff8b7745b) Fix screenshot dimension validation for iPhone 6.9 alias ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/assets/assets_screenshots.go` (+1 -1) 📝 `internal/cli/cmdtest/assets_screenshots_sizes_test.go` (+3 -3) </details> ### 📄 Description ## Summary - Fixes a bug where screenshot dimension validation incorrectly used the canonical API display type (`APP_IPHONE_67`) instead of the original user-specified type (`APP_IPHONE_69`), leading to rejection of valid `1284x2778` dimensions. - Ensures validation uses the full set of dimensions for the user's specified device type, while the API call continues to use the canonical type. - Adds a new test case to specifically validate `IPHONE_69` with `1284x2778` dimensions. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>