[PR #737] [MERGED] ci: run PR checks only on pull_request events #749

Closed
opened 2026-02-26 22:32:23 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/737
Author: @rudrankriyam
Created: 2/23/2026
Status: Merged
Merged: 2/23/2026
Merged by: @rudrankriyam

Base: mainHead: fix/pr-checks-pr-only-clean


📝 Commits (1)

  • 5d946df ci: avoid duplicate PR checks by removing push trigger

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 .github/workflows/pr-checks.yml (+5 -3)

📄 Description

Summary

  • remove the push trigger from .github/workflows/pr-checks.yml so PR Checks runs only on pull requests targeting main
  • add workflow concurrency with cancel-in-progress: true to cancel stale runs when new commits are pushed
  • prevent duplicate check contexts ((push) and (pull_request)) for the same PR commit

Test plan

  • Review workflow diff to confirm only pull_request trigger remains
  • Verify concurrency group is set to pr-checks-${{ github.event.pull_request.number || github.ref }}
  • Open/update branch protection to require the pull_request check contexts only (no (push) contexts)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/737 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/pr-checks-pr-only-clean` --- ### 📝 Commits (1) - [`5d946df`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5d946df8d6649f1263302e03bcafb7cff6eb6c5f) ci: avoid duplicate PR checks by removing push trigger ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/pr-checks.yml` (+5 -3) </details> ### 📄 Description ## Summary - remove the `push` trigger from `.github/workflows/pr-checks.yml` so `PR Checks` runs only on pull requests targeting `main` - add workflow `concurrency` with `cancel-in-progress: true` to cancel stale runs when new commits are pushed - prevent duplicate check contexts (`(push)` and `(pull_request)`) for the same PR commit ## Test plan - [x] Review workflow diff to confirm only `pull_request` trigger remains - [x] Verify concurrency group is set to `pr-checks-${{ github.event.pull_request.number || github.ref }}` - [ ] Open/update branch protection to require the `pull_request` check contexts only (no `(push)` contexts) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 22:32:23 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#749
No description provided.