[PR #715] [MERGED] Asset helper reuse #732

New issue

Closed

opened 2026-02-26 22:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/715
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: feat/cpp-media-upload-sync ← Head: cursor/asset-helper-reuse-b464

📝 Commits (1)

d37fdbb Reuse shared asset helpers for custom page media upload

📊 Changes

3 files changed (+27 additions, -212 deletions)

View changed files

📝 internal/cli/assets/assets_helpers.go (+15 -0)
📝 internal/cli/assets/assets_previews.go (+5 -0)
📝 internal/cli/productpages/custom_page_localization_media_upload.go (+7 -212)

📄 Description

Summary

Refactored duplicated helper functions from internal/cli/productpages/custom_page_localization_media_upload.go into internal/cli/assets/assets_helpers.go and internal/cli/assets/assets_previews.go to promote code reuse and reduce maintenance burden.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/715 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/cpp-media-upload-sync` ← **Head:** `cursor/asset-helper-reuse-b464` --- ### 📝 Commits (1) - [`d37fdbb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d37fdbbe05ac14274c502d472f0403d99d173e71) Reuse shared asset helpers for custom page media upload ### 📊 Changes **3 files changed** (+27 additions, -212 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/assets/assets_helpers.go` (+15 -0) 📝 `internal/cli/assets/assets_previews.go` (+5 -0) 📝 `internal/cli/productpages/custom_page_localization_media_upload.go` (+7 -212) </details> ### 📄 Description ## Summary - Refactored duplicated helper functions from `internal/cli/productpages/custom_page_localization_media_upload.go` into `internal/cli/assets/assets_helpers.go` and `internal/cli/assets/assets_previews.go` to promote code reuse and reduce maintenance burden. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>