[PR #706] [MERGED] Add iPad Pro 13-inch (M5) screenshot dimensions #727

New issue

Closed

opened 2026-02-26 22:32:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/706
Author: @cameronehrlich
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/ipad-pro-m5-screenshot-dimensions

📝 Commits (3)

48866c6 feat(screenshots): add iPad Pro 13-inch (M5) dimensions
a4cd343 fix(screenshots): align iPad Pro M5 validation and tests
7418b4b test(webhooks): make exec payload assertion deterministic

📊 Changes

5 files changed (+96 additions, -28 deletions)

View changed files

📝 internal/asc/screenshot_sizes.go (+8 -5)
📝 internal/asc/screenshot_sizes_test.go (+42 -0)
📝 internal/cli/webhooks/webhooks_serve_test.go (+9 -11)
📝 internal/validation/screenshot_test.go (+19 -0)
📝 internal/validation/screenshots.go (+18 -12)

📄 Description

Summary

The iPad Pro 13-inch (M5) produces screenshots at 2064x2752, which differs from the existing 2048x2732 used by earlier iPad Pro 12.9" models. The App Store Connect API already accepts this size for APP_IPAD_PRO_3GEN_129, but the local validation in asc screenshots upload rejects it.

This adds 2064x2752 to ipadPro129Dimensions using combineDimensions, matching the existing pattern for iphone67Dimensions and iphone69Dimensions which combine multiple device generation resolutions under one display type.

Verification

Uploaded a 2064x2752 screenshot captured from the iPad Pro 13-inch (M5) simulator:

asc screenshots upload \
  --version-localization "..." \
  --path "iPad Pro 13-inch (M5)-02_arrange_vertical.png" \
  --device-type "APP_IPAD_PRO_3GEN_129"

API returned "state": "COMPLETE" — confirmed accepted server-side.

Changes

internal/asc/screenshot_sizes.go: Add 2064x2752 portrait/landscape to ipadPro129Dimensions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/706 **Author:** [@cameronehrlich](https://github.com/cameronehrlich) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/ipad-pro-m5-screenshot-dimensions` --- ### 📝 Commits (3) - [`48866c6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/48866c6647e52da7181aeb5df719e96ee8df07a7) feat(screenshots): add iPad Pro 13-inch (M5) dimensions - [`a4cd343`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a4cd343a9ff4bc3f605055c1f5fbb64cfd241b42) fix(screenshots): align iPad Pro M5 validation and tests - [`7418b4b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7418b4b4a3e916135e79241f5e31c1ed860c9678) test(webhooks): make exec payload assertion deterministic ### 📊 Changes **5 files changed** (+96 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/screenshot_sizes.go` (+8 -5) 📝 `internal/asc/screenshot_sizes_test.go` (+42 -0) 📝 `internal/cli/webhooks/webhooks_serve_test.go` (+9 -11) 📝 `internal/validation/screenshot_test.go` (+19 -0) 📝 `internal/validation/screenshots.go` (+18 -12) </details> ### 📄 Description ## Summary The iPad Pro 13-inch (M5) produces screenshots at **2064x2752**, which differs from the existing 2048x2732 used by earlier iPad Pro 12.9" models. The App Store Connect API already accepts this size for `APP_IPAD_PRO_3GEN_129`, but the local validation in `asc screenshots upload` rejects it. This adds `2064x2752` to `ipadPro129Dimensions` using `combineDimensions`, matching the existing pattern for `iphone67Dimensions` and `iphone69Dimensions` which combine multiple device generation resolutions under one display type. ## Verification Uploaded a 2064x2752 screenshot captured from the iPad Pro 13-inch (M5) simulator: ``` asc screenshots upload \ --version-localization "..." \ --path "iPad Pro 13-inch (M5)-02_arrange_vertical.png" \ --device-type "APP_IPAD_PRO_3GEN_129" ``` API returned `"state": "COMPLETE"` — confirmed accepted server-side. ## Changes - `internal/asc/screenshot_sizes.go`: Add 2064x2752 portrait/landscape to `ipadPro129Dimensions` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>