[PR #701] [MERGED] Metadata locale issues #722

New issue

Closed

opened 2026-02-26 22:32:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/701
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: feat/metadata-fastlane-parity-587 ← Head: cursor/metadata-locale-issues-d4fb

📝 Commits (1)

6bfc0b6 Fix metadata locale delete fallback and normalize validate locale

📊 Changes

5 files changed (+178 additions, -7 deletions)

View changed files

📝 internal/cli/cmdtest/metadata_push_test.go (+117 -0)
📝 internal/cli/metadata/push.go (+6 -4)
📝 internal/cli/metadata/push_test.go (+28 -0)
📝 internal/cli/metadata/validate.go (+4 -3)
📝 internal/cli/metadata/validate_test.go (+23 -0)

📄 Description

Summary

Fixed an issue where default.json fallbacks prevented intentional locale deletions by ensuring fallbacks are only applied when --allow-deletes is not specified.
Corrected validate command output to use normalized locale tokens (e.g., Default) for consistency with other metadata tooling.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/701 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-fastlane-parity-587` ← **Head:** `cursor/metadata-locale-issues-d4fb` --- ### 📝 Commits (1) - [`6bfc0b6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6bfc0b6190a897d6ed82710cd58fbccdd9730b21) Fix metadata locale delete fallback and normalize validate locale ### 📊 Changes **5 files changed** (+178 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/metadata_push_test.go` (+117 -0) 📝 `internal/cli/metadata/push.go` (+6 -4) 📝 `internal/cli/metadata/push_test.go` (+28 -0) 📝 `internal/cli/metadata/validate.go` (+4 -3) 📝 `internal/cli/metadata/validate_test.go` (+23 -0) </details> ### 📄 Description ## Summary - Fixed an issue where `default.json` fallbacks prevented intentional locale deletions by ensuring fallbacks are only applied when `--allow-deletes` is not specified. - Corrected `validate` command output to use normalized locale tokens (e.g., `Default`) for consistency with other metadata tooling. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>