[PR #699] [MERGED] Cli metadata issues #720

New issue

Closed

opened 2026-02-26 22:32:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/699
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/metadata-fastlane-parity-587 ← Head: cursor/cli-metadata-issues-b37e

📝 Commits (1)

b1d4633 Fix metadata push version validation and validate default locale parity

📊 Changes

4 files changed (+45 additions, -5 deletions)

View changed files

📝 internal/cli/metadata/push.go (+5 -1)
📝 internal/cli/metadata/push_test.go (+11 -0)
📝 internal/cli/metadata/validate.go (+5 -4)
📝 internal/cli/metadata/validate_test.go (+24 -0)

📄 Description

Summary

Added path segment validation for the version string in loadLocalMetadata to prevent directory traversal.
Aligned validate command's RequireName option for default locale files with push command's behavior.
Refactored duplicated localization application logic into a generic function to reduce code duplication.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/699 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-fastlane-parity-587` ← **Head:** `cursor/cli-metadata-issues-b37e` --- ### 📝 Commits (1) - [`b1d4633`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b1d4633fc0169a8b7f0cf95b4679e293d3c93c7d) Fix metadata push version validation and validate default locale parity ### 📊 Changes **4 files changed** (+45 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/metadata/push.go` (+5 -1) 📝 `internal/cli/metadata/push_test.go` (+11 -0) 📝 `internal/cli/metadata/validate.go` (+5 -4) 📝 `internal/cli/metadata/validate_test.go` (+24 -0) </details> ### 📄 Description ## Summary - Added path segment validation for the version string in `loadLocalMetadata` to prevent directory traversal. - Aligned `validate` command's `RequireName` option for default locale files with `push` command's behavior. - Refactored duplicated localization application logic into a generic function to reduce code duplication. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>