[PR #684] [MERGED] Wallgen entry generation #712

New issue

Closed

opened 2026-02-26 22:32:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/684
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/wall-of-apps-alphabetical ← Head: cursor/wallgen-entry-generation-1367

📝 Commits (1)

9125fc7 Fix wall entry icon retention, shared sorting, and icon link escaping

📊 Changes

4 files changed (+105 additions, -20 deletions)

View changed files

📝 internal/wallgen/wallgen.go (+13 -6)
📝 internal/wallgen/wallgen_test.go (+36 -0)
📝 tools/generate-app/main.go (+5 -14)
📝 tools/generate-app/main_test.go (+51 -0)

📄 Description

Summary

Preserved existing app icon during updates to prevent data loss on API enrichment failure.
Centralized app entry sorting logic into a shared wallgen.SortEntries function to avoid duplication.
Escaped markdown link delimiters ([ and ]) in icon text to prevent rendering issues.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/684 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/wall-of-apps-alphabetical` ← **Head:** `cursor/wallgen-entry-generation-1367` --- ### 📝 Commits (1) - [`9125fc7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9125fc7181228f601fe32712dc6fbca5534b3d38) Fix wall entry icon retention, shared sorting, and icon link escaping ### 📊 Changes **4 files changed** (+105 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `internal/wallgen/wallgen.go` (+13 -6) 📝 `internal/wallgen/wallgen_test.go` (+36 -0) 📝 `tools/generate-app/main.go` (+5 -14) 📝 `tools/generate-app/main_test.go` (+51 -0) </details> ### 📄 Description ## Summary - Preserved existing app icon during updates to prevent data loss on API enrichment failure. - Centralized app entry sorting logic into a shared `wallgen.SortEntries` function to avoid duplication. - Escaped markdown link delimiters (`[` and `]`) in icon text to prevent rendering issues. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>