[PR #658] [MERGED] feat: support internal beta groups on create/list #688

New issue

Closed

opened 2026-02-26 22:32:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/658
Author: @rudrankriyam
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/testflight-beta-groups-internal

📝 Commits (8)

a07e07b feat: support internal beta groups on create/list
cfed90f fix: use global betaGroups endpoint for internal filter
e746aba fix: apply internal/external filter client-side for --app
4413c69 fix: create internal beta groups via create-only attribute
b58d235 fix: drop invalid beta-groups update --internal flag
2670eca docs: update beta-groups internal examples
0f7f9f8 fix: drop invalid beta-groups update --all-builds flag
94fc3a4 docs: add OpenAPI and live API smoke-test checklist

📊 Changes

9 files changed (+409 additions, -25 deletions)

View changed files

📝 AGENTS.md (+10 -0)
📝 README.md (+7 -1)
📝 internal/asc/client.go (+9 -3)
📝 internal/asc/client_options.go (+7 -0)
📝 internal/asc/client_queries.go (+4 -0)
➕ internal/cli/cmdtest/beta_groups_create_test.go (+130 -0)
📝 internal/cli/cmdtest/beta_groups_global_test.go (+143 -0)
📝 internal/cli/docs/templates/ASC.md (+2 -0)
📝 internal/cli/testflight/beta_groups.go (+97 -21)

📄 Description

Summary

Add asc testflight beta-groups create --internal by setting isInternalGroup=true on the create payload (create-only attribute).
Add asc testflight beta-groups list --internal/--external filters.
- --global: uses ASC server-side filter[isInternalGroup].
- --app: fetches app beta groups and filters client-side (ASC does not allow filter[isInternalGroup] on the app-scoped endpoint).
Remove dead/invalid beta group update flags rejected by ASC:
- beta-groups update --internal (create-only attribute)
- beta-groups update --all-builds (ASC rejects hasAccessToAllBuilds on update)
Update CLI help + docs examples to match the new behavior.
Add cmdtests covering filtering behavior and create --internal request payload.
Update AGENTS.md with an OpenAPI + live smoke-test checklist to avoid dead flags in future.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/658 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/testflight-beta-groups-internal` --- ### 📝 Commits (8) - [`a07e07b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a07e07bb1684f8e268f84db854c762e3a694d07a) feat: support internal beta groups on create/list - [`cfed90f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cfed90f5e72a38ae386efe72b5f9c37b1544d437) fix: use global betaGroups endpoint for internal filter - [`e746aba`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e746abaf0e0d41d06a21814257e51101f6eacfe4) fix: apply internal/external filter client-side for --app - [`4413c69`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4413c6925e659cd4bc0374b71077f8dde32df0a4) fix: create internal beta groups via create-only attribute - [`b58d235`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b58d235f7d0563a012f32e4985227cb08d08e464) fix: drop invalid beta-groups update --internal flag - [`2670eca`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2670eca8b09b6507dabb89ee148b00e9d60cab9a) docs: update beta-groups internal examples - [`0f7f9f8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0f7f9f8b337d12b3754081804dc2d72d2a26d777) fix: drop invalid beta-groups update --all-builds flag - [`94fc3a4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/94fc3a41b6450a2faf2785e1c15712430f4402fa) docs: add OpenAPI and live API smoke-test checklist ### 📊 Changes **9 files changed** (+409 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `AGENTS.md` (+10 -0) 📝 `README.md` (+7 -1) 📝 `internal/asc/client.go` (+9 -3) 📝 `internal/asc/client_options.go` (+7 -0) 📝 `internal/asc/client_queries.go` (+4 -0) ➕ `internal/cli/cmdtest/beta_groups_create_test.go` (+130 -0) 📝 `internal/cli/cmdtest/beta_groups_global_test.go` (+143 -0) 📝 `internal/cli/docs/templates/ASC.md` (+2 -0) 📝 `internal/cli/testflight/beta_groups.go` (+97 -21) </details> ### 📄 Description ## Summary - Add `asc testflight beta-groups create --internal` by setting `isInternalGroup=true` on the create payload (create-only attribute). - Add `asc testflight beta-groups list --internal/--external` filters. - `--global`: uses ASC server-side `filter[isInternalGroup]`. - `--app`: fetches app beta groups and filters client-side (ASC does not allow `filter[isInternalGroup]` on the app-scoped endpoint). - Remove dead/invalid beta group update flags rejected by ASC: - `beta-groups update --internal` (create-only attribute) - `beta-groups update --all-builds` (ASC rejects `hasAccessToAllBuilds` on update) - Update CLI help + docs examples to match the new behavior. - Add cmdtests covering filtering behavior and `create --internal` request payload. - Update `AGENTS.md` with an OpenAPI + live smoke-test checklist to avoid dead flags in future. ## Test plan - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>