[PR #659] [MERGED] ci: don't fail release when tap token invalid #686

New issue

Closed

opened 2026-02-26 22:32:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/659
Author: @rudrankriyam
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/release-homebrew-tap-nonfatal

📝 Commits (2)

55cd81e ci: skip Homebrew tap update on auth failures
f3689ff fix: use correct homebrew-tap repo URL in release workflow

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 .github/workflows/release.yml (+8 -2)

📄 Description

Summary

Prevent the Release workflow from failing when TAP_GITHUB_TOKEN is set but invalid.
If cloning or pushing the tap repo fails, log a warning and skip the tap update.

Why

Releases should still publish artifacts even if Homebrew tap automation fails.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/659 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/release-homebrew-tap-nonfatal` --- ### 📝 Commits (2) - [`55cd81e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/55cd81e0399aa99c0ef46d750ccc94ff1abf1a96) ci: skip Homebrew tap update on auth failures - [`f3689ff`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f3689ff8da39a169b4ecaede06c681814c0ddbe8) fix: use correct homebrew-tap repo URL in release workflow ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+8 -2) </details> ### 📄 Description ## Summary - Prevent the Release workflow from failing when `TAP_GITHUB_TOKEN` is set but invalid. - If cloning or pushing the tap repo fails, log a warning and skip the tap update. ## Why Releases should still publish artifacts even if Homebrew tap automation fails. ## Test plan - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>