[PR #653] [MERGED] Remove self-update and startup update checks #683

New issue

Closed

opened 2026-02-26 22:32:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/653
Author: @rudrankriyam
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/remove-self-update

📝 Commits (1)

3a1b16a chore: remove self-update and update checks

📊 Changes

29 files changed (+19 additions, -1673 deletions)

View changed files

📝 .github/workflows/integration.yml (+0 -1)
📝 AGENTS.md (+0 -1)
📝 Makefile (+0 -1)
📝 README.md (+4 -1)
📝 cmd/exit_codes_test.go (+0 -1)
📝 cmd/run.go (+0 -60)
📝 cmd/run_additional_test.go (+0 -115)
📝 go.mod (+0 -3)
📝 go.sum (+0 -8)
📝 internal/cli/cmdtest/assets_download_media_test.go (+4 -4)
📝 internal/cli/cmdtest/exit_codes_test.go (+6 -6)
📝 internal/cli/cmdtest/release_notes_generate_test.go (+3 -4)
📝 internal/cli/cmdtest/shots_capture_test.go (+2 -2)
📝 internal/cli/docs/templates/ASC.md (+0 -3)
📝 internal/cli/shared/shared.go (+0 -7)
➖ internal/update/cache.go (+0 -60)
➖ internal/update/check.go (+0 -99)
➖ internal/update/download.go (+0 -171)
➖ internal/update/download_test.go (+0 -227)
➖ internal/update/install.go (+0 -44)

...and 9 more files

📄 Description

Summary

Remove startup update checks and the self-update/restart mechanism.
Remove --no-update flag and ASC_NO_UPDATE/ASC_SKIP_UPDATE environment variables.
Delete the internal/update package and update docs/tests/CI accordingly.

Homebrew discourages self-updating binaries in homebrew/core; updates should be handled by the package manager (e.g. brew upgrade).

Test Plan

go test ./...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/653 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/remove-self-update` --- ### 📝 Commits (1) - [`3a1b16a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3a1b16a6ab1706f5e10a20f1ba0784da794b16ba) chore: remove self-update and update checks ### 📊 Changes **29 files changed** (+19 additions, -1673 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/integration.yml` (+0 -1) 📝 `AGENTS.md` (+0 -1) 📝 `Makefile` (+0 -1) 📝 `README.md` (+4 -1) 📝 `cmd/exit_codes_test.go` (+0 -1) 📝 `cmd/run.go` (+0 -60) 📝 `cmd/run_additional_test.go` (+0 -115) 📝 `go.mod` (+0 -3) 📝 `go.sum` (+0 -8) 📝 `internal/cli/cmdtest/assets_download_media_test.go` (+4 -4) 📝 `internal/cli/cmdtest/exit_codes_test.go` (+6 -6) 📝 `internal/cli/cmdtest/release_notes_generate_test.go` (+3 -4) 📝 `internal/cli/cmdtest/shots_capture_test.go` (+2 -2) 📝 `internal/cli/docs/templates/ASC.md` (+0 -3) 📝 `internal/cli/shared/shared.go` (+0 -7) ➖ `internal/update/cache.go` (+0 -60) ➖ `internal/update/check.go` (+0 -99) ➖ `internal/update/download.go` (+0 -171) ➖ `internal/update/download_test.go` (+0 -227) ➖ `internal/update/install.go` (+0 -44) _...and 9 more files_ </details> ### 📄 Description ## Summary - Remove startup update checks and the self-update/restart mechanism. - Remove `--no-update` flag and `ASC_NO_UPDATE`/`ASC_SKIP_UPDATE` environment variables. - Delete the `internal/update` package and update docs/tests/CI accordingly. Homebrew discourages self-updating binaries in `homebrew/core`; updates should be handled by the package manager (e.g. `brew upgrade`). ## Test Plan - `go test ./...` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>