[PR #640] [MERGED] fix: handle apps without Game Center detail #673

New issue

Closed

opened 2026-02-26 22:32:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/640
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/game-center-details-no-detail

📝 Commits (2)

f7728ed fix: handle apps without Game Center detail
04bdbb9 docs(openapi): clarify snapshot sources

📊 Changes

3 files changed (+90 additions, -3 deletions)

View changed files

📝 docs/openapi/README.md (+8 -3)
➕ internal/cli/cmdtest/game_center_details_no_detail_test.go (+71 -0)
📝 internal/cli/gamecenter/game_center_details.go (+11 -0)

📄 Description

Summary

Fix asc game-center details list --app ... when App Store Connect returns a 200 response with an empty Game Center detail id.
Print a warning + return an empty list instead of requesting /v1/gameCenterDetails/.
Add cmdtest coverage for the empty-id response.

Notes

Also clarifies OpenAPI snapshot sources in docs/openapi/README.md (Apple zip + EvanBacon mirror) and updates the last synced date.

Test Plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/640 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/game-center-details-no-detail` --- ### 📝 Commits (2) - [`f7728ed`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f7728edc838f8e119f4b2156f6658132896a63f9) fix: handle apps without Game Center detail - [`04bdbb9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/04bdbb9b1c06860845c540485a2775fdb828277e) docs(openapi): clarify snapshot sources ### 📊 Changes **3 files changed** (+90 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/openapi/README.md` (+8 -3) ➕ `internal/cli/cmdtest/game_center_details_no_detail_test.go` (+71 -0) 📝 `internal/cli/gamecenter/game_center_details.go` (+11 -0) </details> ### 📄 Description ## Summary - Fix `asc game-center details list --app ...` when App Store Connect returns a 200 response with an empty Game Center detail id. - Print a warning + return an empty list instead of requesting `/v1/gameCenterDetails/`. - Add cmdtest coverage for the empty-id response. ## Notes - Also clarifies OpenAPI snapshot sources in `docs/openapi/README.md` (Apple zip + EvanBacon mirror) and updates the last synced date. ## Test Plan - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>