[PR #638] [MERGED] Linkages helper consolidation #670

New issue

Closed

opened 2026-02-26 22:32:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/638
Author: @cursor[bot]
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: cursor/issue-618-game-center-relationships ← Head: cursor/linkages-helper-consolidation-bb84

📝 Commits (1)

4ab0d9f asc: consolidate Game Center linkages helpers

📊 Changes

7 files changed (+134 additions, -284 deletions)

View changed files

📝 internal/asc/client_game_center_achievements_relationships.go (+18 -62)
📝 internal/asc/client_game_center_activities_relationships.go (+18 -62)
📝 internal/asc/client_game_center_app_versions_relationships.go (+9 -31)
📝 internal/asc/client_game_center_challenges_relationships.go (+18 -62)
📝 internal/asc/client_game_center_enabled_versions_relationships.go (+9 -32)
📝 internal/asc/client_game_center_matchmaking_relationships.go (+9 -35)
➕ internal/asc/client_linkages_generic.go (+53 -0)

📄 Description

Summary

Refactored nine identical private get*Linkages helper functions into a single generic getResourceLinkages function to reduce code duplication and improve maintainability.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/638 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/issue-618-game-center-relationships` ← **Head:** `cursor/linkages-helper-consolidation-bb84` --- ### 📝 Commits (1) - [`4ab0d9f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4ab0d9f011e1da703a1b721ce5ba201583126bf4) asc: consolidate Game Center linkages helpers ### 📊 Changes **7 files changed** (+134 additions, -284 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_game_center_achievements_relationships.go` (+18 -62) 📝 `internal/asc/client_game_center_activities_relationships.go` (+18 -62) 📝 `internal/asc/client_game_center_app_versions_relationships.go` (+9 -31) 📝 `internal/asc/client_game_center_challenges_relationships.go` (+18 -62) 📝 `internal/asc/client_game_center_enabled_versions_relationships.go` (+9 -32) 📝 `internal/asc/client_game_center_matchmaking_relationships.go` (+9 -35) ➕ `internal/asc/client_linkages_generic.go` (+53 -0) </details> ### 📄 Description ## Summary - Refactored nine identical private `get*Linkages` helper functions into a single generic `getResourceLinkages` function to reduce code duplication and improve maintainability. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>