[PR #629] [MERGED] Missing relationship endpoints #662

New issue

Closed

opened 2026-02-26 22:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/629
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/missing-relationship-endpoints-c4f7

📝 Commits (2)

d6a1a37 asc: add remaining missing relationship endpoints
1bb639e fix: align bundleId relationships with production

📊 Changes

21 files changed (+1020 additions, -0 deletions)

View changed files

📝 internal/asc/analytics.go (+34 -0)
📝 internal/asc/analytics_test.go (+20 -0)
📝 internal/asc/categories.go (+62 -0)
📝 internal/asc/client_alternative_distribution.go (+44 -0)
📝 internal/asc/client_app_encryption_relationships.go (+54 -0)
📝 internal/asc/client_bundle_id_relationships.go (+73 -0)
📝 internal/asc/client_game_center.go (+22 -0)
📝 internal/asc/client_game_center_v2.go (+156 -0)
📝 internal/asc/client_http_alternative_distribution_test.go (+40 -0)
➕ internal/asc/client_http_categories_test.go (+44 -0)
📝 internal/asc/client_http_gamecenter_test.go (+17 -0)
📝 internal/asc/client_http_gamecenter_v2_test.go (+111 -0)
📝 internal/asc/client_http_relationships_test.go (+88 -0)
📝 internal/asc/client_http_test.go (+34 -0)
📝 internal/asc/client_pricing.go (+31 -0)
📝 internal/asc/client_user_invitation_visible_apps.go (+30 -0)
📝 internal/asc/eula.go (+31 -0)
📝 internal/asc/pricing_test.go (+17 -0)
📝 internal/asc/review_responses.go (+27 -0)
📝 internal/asc/review_responses_test.go (+27 -0)

...and 1 more files

📄 Description

Summary

Implements all 21 missing GET relationship endpoints for various resources, completing API coverage as per #623.
Adds corresponding client methods and comprehensive request-shaping tests, ensuring correct to-one/to-many JSON response handling.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/629 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/missing-relationship-endpoints-c4f7` --- ### 📝 Commits (2) - [`d6a1a37`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d6a1a3729e6710a82314d55a901c10ea9950809f) asc: add remaining missing relationship endpoints - [`1bb639e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1bb639e1660b6e57528907b3330f8ceb72f66f49) fix: align bundleId relationships with production ### 📊 Changes **21 files changed** (+1020 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/analytics.go` (+34 -0) 📝 `internal/asc/analytics_test.go` (+20 -0) 📝 `internal/asc/categories.go` (+62 -0) 📝 `internal/asc/client_alternative_distribution.go` (+44 -0) 📝 `internal/asc/client_app_encryption_relationships.go` (+54 -0) 📝 `internal/asc/client_bundle_id_relationships.go` (+73 -0) 📝 `internal/asc/client_game_center.go` (+22 -0) 📝 `internal/asc/client_game_center_v2.go` (+156 -0) 📝 `internal/asc/client_http_alternative_distribution_test.go` (+40 -0) ➕ `internal/asc/client_http_categories_test.go` (+44 -0) 📝 `internal/asc/client_http_gamecenter_test.go` (+17 -0) 📝 `internal/asc/client_http_gamecenter_v2_test.go` (+111 -0) 📝 `internal/asc/client_http_relationships_test.go` (+88 -0) 📝 `internal/asc/client_http_test.go` (+34 -0) 📝 `internal/asc/client_pricing.go` (+31 -0) 📝 `internal/asc/client_user_invitation_visible_apps.go` (+30 -0) 📝 `internal/asc/eula.go` (+31 -0) 📝 `internal/asc/pricing_test.go` (+17 -0) 📝 `internal/asc/review_responses.go` (+27 -0) 📝 `internal/asc/review_responses_test.go` (+27 -0) _...and 1 more files_ </details> ### 📄 Description ## Summary - Implements all 21 missing GET relationship endpoints for various resources, completing API coverage as per #623. - Adds corresponding client methods and comprehensive request-shaping tests, ensuring correct to-one/to-many JSON response handling. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-4b68e286-6816-4bd8-85e5-7c17f93cc889"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-4b68e286-6816-4bd8-85e5-7c17f93cc889"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>