[PR #626] [MERGED] Missing OpenAPI endpoints #661

New issue

Closed

opened 2026-02-26 22:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/626
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/missing-openapi-endpoints-926a

📝 Commits (1)

b243433 coverage: add missing OpenAPI endpoints

📊 Changes

7 files changed (+428 additions, -0 deletions)

View changed files

📝 internal/asc/client.go (+33 -0)
➕ internal/asc/client_app_info_localizations_detail_test.go (+45 -0)
📝 internal/asc/client_game_center.go (+48 -0)
➕ internal/asc/client_game_center_releases_detail_test.go (+76 -0)
➕ internal/asc/client_iap_missing_endpoints_test.go (+99 -0)
📝 internal/asc/client_iap_subresources.go (+93 -0)
📝 internal/asc/iap_resources.go (+34 -0)

📄 Description

Summary

Implemented 8 missing non-relationship endpoints from the App Store Connect API OpenAPI snapshot.
Added client methods for:
- GET /v1/appInfoLocalizations/{id}
- DELETE /v1/appInfoLocalizations/{id}
- GET /v1/gameCenterAchievementReleases/{id}
- GET /v1/gameCenterLeaderboardReleases/{id}
- GET /v1/gameCenterLeaderboardSetReleases/{id}
- GET /v1/inAppPurchaseLocalizations/{id}
- PATCH /v1/inAppPurchaseOfferCodeCustomCodes/{id}
- PATCH /v1/inAppPurchaseOfferCodeOneTimeUseCodes/{id}
Included new request-shaping tests for all added endpoints.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/626 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/missing-openapi-endpoints-926a` --- ### 📝 Commits (1) - [`b243433`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b24343312bfbd2e53d0f168cae538939d9593bdb) coverage: add missing OpenAPI endpoints ### 📊 Changes **7 files changed** (+428 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client.go` (+33 -0) ➕ `internal/asc/client_app_info_localizations_detail_test.go` (+45 -0) 📝 `internal/asc/client_game_center.go` (+48 -0) ➕ `internal/asc/client_game_center_releases_detail_test.go` (+76 -0) ➕ `internal/asc/client_iap_missing_endpoints_test.go` (+99 -0) 📝 `internal/asc/client_iap_subresources.go` (+93 -0) 📝 `internal/asc/iap_resources.go` (+34 -0) </details> ### 📄 Description ## Summary - Implemented 8 missing non-relationship endpoints from the App Store Connect API OpenAPI snapshot. - Added client methods for: - `GET /v1/appInfoLocalizations/{id}` - `DELETE /v1/appInfoLocalizations/{id}` - `GET /v1/gameCenterAchievementReleases/{id}` - `GET /v1/gameCenterLeaderboardReleases/{id}` - `GET /v1/gameCenterLeaderboardSetReleases/{id}` - `GET /v1/inAppPurchaseLocalizations/{id}` - `PATCH /v1/inAppPurchaseOfferCodeCustomCodes/{id}` - `PATCH /v1/inAppPurchaseOfferCodeOneTimeUseCodes/{id}` - Included new request-shaping tests for all added endpoints. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-f5e0f383-4b93-4ea6-8120-1afde7401653"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-f5e0f383-4b93-4ea6-8120-1afde7401653"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>