[PR #583] [MERGED] screenshots: allow JSONC comments in plans #637

New issue

Closed

opened 2026-02-26 22:31:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/583
Author: @rudrankriyam
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: main ← Head: jsonc-screenshots-plan

📝 Commits (1)

3b07252 screenshots: allow JSONC comments in plans

📊 Changes

5 files changed (+87 additions, -2 deletions)

View changed files

📝 go.mod (+3 -2)
📝 go.sum (+2 -0)
📝 internal/cli/cmdtest/shots_run_test.go (+52 -0)
📝 internal/screenshots/plan.go (+4 -0)
📝 internal/screenshots/plan_test.go (+26 -0)

📄 Description

Summary

Allow JSONC-style comments (// and /* */) in screenshot automation plan files without changing the .json format.
Strip comments before encoding/json unmarshalling via github.com/tidwall/jsonc.
Add unit + CLI cmdtest coverage for commented plan files.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/583 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `jsonc-screenshots-plan` --- ### 📝 Commits (1) - [`3b07252`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3b07252eb9c8d288d8f6c15fe48eb82740c3f048) screenshots: allow JSONC comments in plans ### 📊 Changes **5 files changed** (+87 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+3 -2) 📝 `go.sum` (+2 -0) 📝 `internal/cli/cmdtest/shots_run_test.go` (+52 -0) 📝 `internal/screenshots/plan.go` (+4 -0) 📝 `internal/screenshots/plan_test.go` (+26 -0) </details> ### 📄 Description ## Summary - Allow JSONC-style comments (`//` and `/* */`) in screenshot automation plan files without changing the `.json` format. - Strip comments before `encoding/json` unmarshalling via `github.com/tidwall/jsonc`. - Add unit + CLI cmdtest coverage for commented plan files. ## Test plan - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>