[PR #573] [MERGED] Profiles local command issues #631

New issue

Closed

opened 2026-02-26 22:31:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/573
Author: @cursor[bot]
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: profiles/local-management ← Head: cursor/profiles-local-command-issues-9d52

📝 Commits (1)

ccef96a Fix profiles local install/clean status reporting

📊 Changes

2 files changed (+125 additions, -1 deletions)

View changed files

📝 internal/cli/cmdtest/profiles_local_test.go (+114 -0)
📝 internal/cli/profiles/local.go (+11 -1)

📄 Description

Summary

Corrected profiles local install --force to accurately report "replaced" only when an existing profile is actually overwritten.
Added validation to profiles local clean to require a cleanup mode (e.g., --expired or --all) when --confirm is used, preventing silent no-op runs.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/573 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `profiles/local-management` ← **Head:** `cursor/profiles-local-command-issues-9d52` --- ### 📝 Commits (1) - [`ccef96a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ccef96a220f3c2aed644d91923f80df93d2e79c6) Fix profiles local install/clean status reporting ### 📊 Changes **2 files changed** (+125 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/profiles_local_test.go` (+114 -0) 📝 `internal/cli/profiles/local.go` (+11 -1) </details> ### 📄 Description ## Summary - Corrected `profiles local install --force` to accurately report "replaced" only when an existing profile is actually overwritten. - Added validation to `profiles local clean` to require a cleanup mode (e.g., `--expired` or `--all`) when `--confirm` is used, preventing silent no-op runs. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>