[PR #548] [CLOSED] Build upload table rendering #610

New issue

Closed

opened 2026-02-26 22:31:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/548
Author: @cursor[bot]
Created: 2/14/2026
Status: ❌ Closed

Base: cursor/appstoreconnectcli-async-await-f47d ← Head: cursor/build-upload-table-rendering-edb0

📝 Commits (10+)

0d15553 refactor: unify polling loops with shared helper
921d6cc refactor: centralize secure open nofollow logic
ddc2861 perf: cache asc config loads in runtime resolvers
dc393a4 refactor(asc): reduce output registry boilerplate
438c6ee refactor(cli): consolidate output flag binding and rendering helpers
86049df test(asc): verify response-data registry helper registration
798f1f5 refactor(cli): share allowed output-format validation
7574b07 refactor(cli): harden allowed output-format validation defaults
ac22698 fix(asc): retry config load after transient failures
7d060a9 test(asc): add poll helper interval and mid-cancel coverage

📊 Changes

256 files changed (+4039 additions, -3851 deletions)

View changed files

📝 internal/asc/client_core.go (+40 -2)
➕ internal/asc/client_core_config_cache_test.go (+118 -0)
📝 internal/asc/client_publish.go (+6 -14)
📝 internal/asc/output_registry.go (+95 -16)
📝 internal/asc/output_registry_init.go (+200 -588)
📝 internal/asc/output_registry_test.go (+472 -7)
➕ internal/asc/poll.go (+52 -0)
➕ internal/asc/poll_test.go (+133 -0)
📝 internal/asc/secure_open_other.go (+6 -2)
📝 internal/asc/secure_open_unix.go (+2 -3)
📝 internal/cli/accessibility/accessibility.go (+11 -16)
📝 internal/cli/actors/actors.go (+5 -7)
📝 internal/cli/agerating/age_rating.go (+4 -6)
📝 internal/cli/agreements/agreements.go (+3 -4)
📝 internal/cli/alternativedistribution/alternative_distribution_domains.go (+9 -13)
📝 internal/cli/alternativedistribution/alternative_distribution_keys.go (+11 -16)
📝 internal/cli/alternativedistribution/alternative_distribution_package_versions.go (+11 -15)
📝 internal/cli/alternativedistribution/alternative_distribution_packages.go (+10 -15)
📝 internal/cli/analytics/analytics_instances.go (+5 -7)
📝 internal/cli/analytics/analytics_reports.go (+5 -7)

...and 80 more files

📄 Description

Summary

Fixes a regression where BuildUploadResponse and BuildUploadFileResponse were not correctly registered for table/markdown output, causing CLI commands to silently fall back to JSON output when --output table or --output markdown was specified. This was due to a type mismatch in the registration helper.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/548 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ❌ Closed **Base:** `cursor/appstoreconnectcli-async-await-f47d` ← **Head:** `cursor/build-upload-table-rendering-edb0` --- ### 📝 Commits (10+) - [`0d15553`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0d1555341a8a84f415bb73124484cde8746dbb2e) refactor: unify polling loops with shared helper - [`921d6cc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/921d6cc185457085453e257f4a0d9324fa5deffb) refactor: centralize secure open nofollow logic - [`ddc2861`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ddc2861092a3283aa48ad5a9a63f71d96bf4bab7) perf: cache asc config loads in runtime resolvers - [`dc393a4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/dc393a4097122615ec8430a486712cec9f4e6a48) refactor(asc): reduce output registry boilerplate - [`438c6ee`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/438c6ee33d5f25e9764ed0a7f034fe1d46bfa713) refactor(cli): consolidate output flag binding and rendering helpers - [`86049df`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/86049dfed5a410aa4c4a1b6a49044b1919fe8773) test(asc): verify response-data registry helper registration - [`798f1f5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/798f1f56bc1d512ada949e7ebf0df01fb0f71468) refactor(cli): share allowed output-format validation - [`7574b07`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7574b074d9cea5ab8e896db16ed95e396d354379) refactor(cli): harden allowed output-format validation defaults - [`ac22698`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ac226983a295699920d0fca2b4490ba32b7001ff) fix(asc): retry config load after transient failures - [`7d060a9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7d060a948c84b602fa24917941ee35308129a38a) test(asc): add poll helper interval and mid-cancel coverage ### 📊 Changes **256 files changed** (+4039 additions, -3851 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_core.go` (+40 -2) ➕ `internal/asc/client_core_config_cache_test.go` (+118 -0) 📝 `internal/asc/client_publish.go` (+6 -14) 📝 `internal/asc/output_registry.go` (+95 -16) 📝 `internal/asc/output_registry_init.go` (+200 -588) 📝 `internal/asc/output_registry_test.go` (+472 -7) ➕ `internal/asc/poll.go` (+52 -0) ➕ `internal/asc/poll_test.go` (+133 -0) 📝 `internal/asc/secure_open_other.go` (+6 -2) 📝 `internal/asc/secure_open_unix.go` (+2 -3) 📝 `internal/cli/accessibility/accessibility.go` (+11 -16) 📝 `internal/cli/actors/actors.go` (+5 -7) 📝 `internal/cli/agerating/age_rating.go` (+4 -6) 📝 `internal/cli/agreements/agreements.go` (+3 -4) 📝 `internal/cli/alternativedistribution/alternative_distribution_domains.go` (+9 -13) 📝 `internal/cli/alternativedistribution/alternative_distribution_keys.go` (+11 -16) 📝 `internal/cli/alternativedistribution/alternative_distribution_package_versions.go` (+11 -15) 📝 `internal/cli/alternativedistribution/alternative_distribution_packages.go` (+10 -15) 📝 `internal/cli/analytics/analytics_instances.go` (+5 -7) 📝 `internal/cli/analytics/analytics_reports.go` (+5 -7) _...and 80 more files_ </details> ### 📄 Description ## Summary Fixes a regression where `BuildUploadResponse` and `BuildUploadFileResponse` were not correctly registered for table/markdown output, causing CLI commands to silently fall back to JSON output when `--output table` or `--output markdown` was specified. This was due to a type mismatch in the registration helper. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>