[PR #541] [MERGED] Wire top-level screenshots and video-previews commands #605

New issue

Closed

opened 2026-02-26 22:31:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/541
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/screenshots-wiring

📝 Commits (5)

dd61a03 feat(cli): group root help and clarify media wording
65359bf docs: add screenshots wiring implementation checklist
45bb59d feat(cli): add top-level screenshots and video-previews commands
e67a7a7 refactor(cli): remove obsolete assets/shots wrapper commands
b65f6f6 merge: sync main into screenshots wiring branch

📊 Changes

37 files changed (+359 additions, -345 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 ASC.md (+2 -2)
📝 README.md (+20 -11)
📝 cmd/root_usage.go (+2 -2)
📝 cmd/run_additional_test.go (+35 -0)
📝 internal/asc/screenshot_sizes.go (+1 -1)
📝 internal/asc/screenshot_sizes_test.go (+1 -1)
➖ internal/cli/assets/assets.go (+0 -35)
📝 internal/cli/assets/assets_previews.go (+21 -21)
📝 internal/cli/assets/assets_screenshots.go (+29 -29)
📝 internal/cli/assets/assets_test.go (+1 -19)
➖ internal/cli/assets/commands.go (+0 -8)
📝 internal/cli/cmdtest/assets_screenshots_sizes_test.go (+8 -8)
📝 internal/cli/cmdtest/commands_test.go (+25 -25)
📝 internal/cli/cmdtest/shots_capture_test.go (+8 -8)
📝 internal/cli/cmdtest/shots_frame_test.go (+9 -9)
📝 internal/cli/cmdtest/shots_frames_list_devices_test.go (+1 -1)
📝 internal/cli/cmdtest/shots_review_generate_test.go (+2 -2)
📝 internal/cli/cmdtest/shots_review_open_approve_test.go (+4 -4)
📝 internal/cli/cmdtest/shots_run_test.go (+4 -4)

...and 17 more files

📄 Description

Summary

add new top-level screenshots and video-previews commands and wire existing handlers under a flat, single-level UX
remove top-level shots and assets exposure from root help/registry and update grouped root help coverage
update command usage/help/docs/tests and align subcommand descriptions in shared help output for long names

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test
go run . --help
go run . screenshots --help
go run . video-previews --help
go run . screenshots list-frame-devices --output json

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/541 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/screenshots-wiring` --- ### 📝 Commits (5) - [`dd61a03`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/dd61a03e3661c4c448fb3bb107e628eba0c8df86) feat(cli): group root help and clarify media wording - [`65359bf`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/65359bfee8af9659282e3e9e7adb268db8502dc2) docs: add screenshots wiring implementation checklist - [`45bb59d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/45bb59d7aa70158118b0b90b17b8460b28359084) feat(cli): add top-level screenshots and video-previews commands - [`e67a7a7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e67a7a77ceeb205810941edac34a3acf336cc67b) refactor(cli): remove obsolete assets/shots wrapper commands - [`b65f6f6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b65f6f6f63b9da030fc46ce5c65eb3dca1693a33) merge: sync main into screenshots wiring branch ### 📊 Changes **37 files changed** (+359 additions, -345 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `ASC.md` (+2 -2) 📝 `README.md` (+20 -11) 📝 `cmd/root_usage.go` (+2 -2) 📝 `cmd/run_additional_test.go` (+35 -0) 📝 `internal/asc/screenshot_sizes.go` (+1 -1) 📝 `internal/asc/screenshot_sizes_test.go` (+1 -1) ➖ `internal/cli/assets/assets.go` (+0 -35) 📝 `internal/cli/assets/assets_previews.go` (+21 -21) 📝 `internal/cli/assets/assets_screenshots.go` (+29 -29) 📝 `internal/cli/assets/assets_test.go` (+1 -19) ➖ `internal/cli/assets/commands.go` (+0 -8) 📝 `internal/cli/cmdtest/assets_screenshots_sizes_test.go` (+8 -8) 📝 `internal/cli/cmdtest/commands_test.go` (+25 -25) 📝 `internal/cli/cmdtest/shots_capture_test.go` (+8 -8) 📝 `internal/cli/cmdtest/shots_frame_test.go` (+9 -9) 📝 `internal/cli/cmdtest/shots_frames_list_devices_test.go` (+1 -1) 📝 `internal/cli/cmdtest/shots_review_generate_test.go` (+2 -2) 📝 `internal/cli/cmdtest/shots_review_open_approve_test.go` (+4 -4) 📝 `internal/cli/cmdtest/shots_run_test.go` (+4 -4) _...and 17 more files_ </details> ### 📄 Description ## Summary - add new top-level `screenshots` and `video-previews` commands and wire existing handlers under a flat, single-level UX - remove top-level `shots` and `assets` exposure from root help/registry and update grouped root help coverage - update command usage/help/docs/tests and align subcommand descriptions in shared help output for long names ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` - [x] `go run . --help` - [x] `go run . screenshots --help` - [x] `go run . video-previews --help` - [x] `go run . screenshots list-frame-devices --output json` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>