[PR #530] [MERGED] Keychain migration cleanup scope #595

New issue

Closed

opened 2026-02-26 22:31:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/530
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/keychain-migration-cleanup-scope-50c1

📝 Commits (2)

b6034f4 Fix keychain migration cleanup across config scopes
dcc4e25 Remove unused config cleanup wrapper

📊 Changes

2 files changed (+228 additions, -18 deletions)

View changed files

📝 internal/auth/keychain.go (+48 -18)
📝 internal/auth/keychain_test.go (+180 -0)

📄 Description

Summary

Refactors keychain credential cleanup to correctly remove stale profiles from both active and global configuration paths, addressing a bug where global config could retain old credentials. Introduces path-scoped removal and adds regression tests for mixed local/global config scenarios.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/530 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/keychain-migration-cleanup-scope-50c1` --- ### 📝 Commits (2) - [`b6034f4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b6034f461e8a60ddc58101bf450476dfc95f0332) Fix keychain migration cleanup across config scopes - [`dcc4e25`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/dcc4e25a4ae11c4405c5af70e995a7ae4c118454) Remove unused config cleanup wrapper ### 📊 Changes **2 files changed** (+228 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/keychain.go` (+48 -18) 📝 `internal/auth/keychain_test.go` (+180 -0) </details> ### 📄 Description ## Summary Refactors keychain credential cleanup to correctly remove stale profiles from both active and global configuration paths, addressing a bug where global config could retain old credentials. Introduces path-scoped removal and adds regression tests for mixed local/global config scenarios. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-6575c373-004e-4fab-b340-34cc4de2d208"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-6575c373-004e-4fab-b340-34cc4de2d208"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>