[PR #529] [MERGED] Asc bypass keychain empty #593

New issue

Closed

opened 2026-02-26 22:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/529
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/asc-bypass-keychain-empty-2971

📝 Commits (3)

5a10bda fix(auth): require explicit truthy ASC_BYPASS_KEYCHAIN
4145114 Merge remote-tracking branch 'origin/main' into cursor/asc-bypass-keychain-empty-2971
c0ffeba docs: require ASC_BYPASS_KEYCHAIN for local tests

📊 Changes

8 files changed (+104 additions, -15 deletions)

View changed files

📝 AGENTS.md (+3 -2)
📝 README.md (+5 -3)
📝 internal/auth/doctor.go (+2 -2)
📝 internal/auth/doctor_test.go (+16 -0)
📝 internal/auth/keychain.go (+3 -4)
📝 internal/auth/keychain_test.go (+48 -0)
📝 internal/cli/auth/auth.go (+5 -4)
📝 internal/cli/auth/auth_test.go (+22 -0)

📄 Description

Summary

Fixed ASC_BYPASS_KEYCHAIN environment variable parsing to require explicit truthy values (1, true, yes, on) for bypassing the system keychain. Unset, empty, whitespace, or invalid values no longer bypass.
Updated auth status, doctor, command help, and README.md messaging to reflect the new explicit truthy/falsey semantics and remove hardcoded ASC_BYPASS_KEYCHAIN=1 references.
Added comprehensive table-driven tests for shouldBypassKeychain() covering unset, empty, whitespace, truthy, falsey, and invalid values.
Added CLI-level assertions to ensure messaging correctly handles non-1 truthy values (e.g., yes).

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/529 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/asc-bypass-keychain-empty-2971` --- ### 📝 Commits (3) - [`5a10bda`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5a10bdacba40568c19953df16ee60686b7fc2648) fix(auth): require explicit truthy ASC_BYPASS_KEYCHAIN - [`4145114`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/414511497de87e9830ba7b230d3ce2b8d7993696) Merge remote-tracking branch 'origin/main' into cursor/asc-bypass-keychain-empty-2971 - [`c0ffeba`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c0ffebac9aa0b6d25cb680f97a6497317d1967f9) docs: require ASC_BYPASS_KEYCHAIN for local tests ### 📊 Changes **8 files changed** (+104 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `AGENTS.md` (+3 -2) 📝 `README.md` (+5 -3) 📝 `internal/auth/doctor.go` (+2 -2) 📝 `internal/auth/doctor_test.go` (+16 -0) 📝 `internal/auth/keychain.go` (+3 -4) 📝 `internal/auth/keychain_test.go` (+48 -0) 📝 `internal/cli/auth/auth.go` (+5 -4) 📝 `internal/cli/auth/auth_test.go` (+22 -0) </details> ### 📄 Description ## Summary - Fixed `ASC_BYPASS_KEYCHAIN` environment variable parsing to require explicit truthy values (`1`, `true`, `yes`, `on`) for bypassing the system keychain. Unset, empty, whitespace, or invalid values no longer bypass. - Updated `auth status`, `doctor`, command help, and `README.md` messaging to reflect the new explicit truthy/falsey semantics and remove hardcoded `ASC_BYPASS_KEYCHAIN=1` references. - Added comprehensive table-driven tests for `shouldBypassKeychain()` covering unset, empty, whitespace, truthy, falsey, and invalid values. - Added CLI-level assertions to ensure messaging correctly handles non-`1` truthy values (e.g., `yes`). ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-af09e7be-3d77-4fab-9085-6b5537ce37ef"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-af09e7be-3d77-4fab-9085-6b5537ce37ef"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>