[PR #528] [MERGED] Strict auth value handling #592

New issue

Closed

opened 2026-02-26 22:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/528
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/strict-auth-value-handling-27f3

📝 Commits (1)

611b04f Handle ASC_STRICT_AUTH yes/no values with warnings

📊 Changes

5 files changed (+116 additions, -8 deletions)

View changed files

📝 AGENTS.md (+1 -1)
📝 README.md (+2 -2)
📝 internal/cli/auth/auth.go (+1 -1)
📝 internal/cli/shared/shared.go (+12 -4)
📝 internal/cli/shared/shared_test.go (+100 -0)

📄 Description

Summary

This PR expands the accepted values for the ASC_STRICT_AUTH environment variable to include common truthy/falsey forms (e.g., yes, on, 0, false). It also introduces a stderr warning for invalid ASC_STRICT_AUTH values, preventing silent misconfiguration.

Comprehensive tests have been added for the new parsing logic, and all user-facing documentation and help text have been updated to reflect the explicit accepted values.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/528 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/strict-auth-value-handling-27f3` --- ### 📝 Commits (1) - [`611b04f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/611b04f5df7fdd77bba7b222c55fd467bad94a37) Handle ASC_STRICT_AUTH yes/no values with warnings ### 📊 Changes **5 files changed** (+116 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `AGENTS.md` (+1 -1) 📝 `README.md` (+2 -2) 📝 `internal/cli/auth/auth.go` (+1 -1) 📝 `internal/cli/shared/shared.go` (+12 -4) 📝 `internal/cli/shared/shared_test.go` (+100 -0) </details> ### 📄 Description ## Summary This PR expands the accepted values for the `ASC_STRICT_AUTH` environment variable to include common truthy/falsey forms (e.g., `yes`, `on`, `0`, `false`). It also introduces a `stderr` warning for invalid `ASC_STRICT_AUTH` values, preventing silent misconfiguration. Comprehensive tests have been added for the new parsing logic, and all user-facing documentation and help text have been updated to reflect the explicit accepted values. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-0bd4311d-2943-4fa7-b750-62126c5b3ff3"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-0bd4311d-2943-4fa7-b750-62126c5b3ff3"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>