[PR #516] [MERGED] Cli and screenshots issues #591

New issue

Closed

opened 2026-02-26 22:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/516
Author: @cursor[bot]
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: feat/shots-capture-mvp ← Head: cursor/cli-and-screenshots-issues-9488

📝 Commits (1)

3912c8f Fix shots frame config filename device and remove dead exports

📊 Changes

5 files changed (+79 additions, -24 deletions)

View changed files

📝 internal/cli/cmdtest/shots_frame_test.go (+59 -0)
➖ internal/cli/shots/commands.go (+0 -8)
📝 internal/cli/shots/shots_frame.go (+6 -1)
📝 internal/screenshots/frame.go (+14 -0)
📝 internal/screenshots/review.go (+0 -15)

📄 Description

Summary

Removed unused shots.Command() wrapper.
Unexported unused ReviewManifestPath, ReviewHTMLPath, and ReviewApprovalsPath functions.
Corrected shots frame command to use the device from the config for output filenames when --config is specified.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/516 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/cli-and-screenshots-issues-9488` --- ### 📝 Commits (1) - [`3912c8f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3912c8f40494582648474cce53cfab3fdb2dbcdf) Fix shots frame config filename device and remove dead exports ### 📊 Changes **5 files changed** (+79 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/shots_frame_test.go` (+59 -0) ➖ `internal/cli/shots/commands.go` (+0 -8) 📝 `internal/cli/shots/shots_frame.go` (+6 -1) 📝 `internal/screenshots/frame.go` (+14 -0) 📝 `internal/screenshots/review.go` (+0 -15) </details> ### 📄 Description ## Summary - Removed unused `shots.Command()` wrapper. - Unexported unused `ReviewManifestPath`, `ReviewHTMLPath`, and `ReviewApprovalsPath` functions. - Corrected `shots frame` command to use the device from the config for output filenames when `--config` is specified. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>