[PR #526] [MERGED] Upload timeout resolution #590

New issue

Closed

opened 2026-02-26 22:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/526
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/upload-timeout-resolution-907d

📝 Commits (1)

0ab3178 Use upload timeout for asset file uploads

📊 Changes

2 files changed (+80 additions, -1 deletions)

View changed files

📝 internal/asc/assets_upload.go (+1 -1)
📝 internal/asc/assets_upload_test.go (+79 -0)

📄 Description

Summary

Fixes UploadAssetFromFile to correctly use ASC_UPLOAD_TIMEOUT for HTTP client timeouts, rather than ASC_TIMEOUT.
Adds new behavioral tests to explicitly verify that ASC_UPLOAD_TIMEOUT is honored, covering both success (longer upload timeout) and failure (shorter upload timeout) scenarios.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/526 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/upload-timeout-resolution-907d` --- ### 📝 Commits (1) - [`0ab3178`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0ab3178537297b28ec71ca25dc186159a45447d7) Use upload timeout for asset file uploads ### 📊 Changes **2 files changed** (+80 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/assets_upload.go` (+1 -1) 📝 `internal/asc/assets_upload_test.go` (+79 -0) </details> ### 📄 Description ## Summary - Fixes `UploadAssetFromFile` to correctly use `ASC_UPLOAD_TIMEOUT` for HTTP client timeouts, rather than `ASC_TIMEOUT`. - Adds new behavioral tests to explicitly verify that `ASC_UPLOAD_TIMEOUT` is honored, covering both success (longer upload timeout) and failure (shorter upload timeout) scenarios. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- <p><a href="https://cursor.com/background-agent?bcId=bc-689502de-e55f-4c3a-8675-17dfd8162779"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-689502de-e55f-4c3a-8675-17dfd8162779"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>