[PR #527] [MERGED] Auth output hygiene #589

New issue

Closed

opened 2026-02-26 22:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/527
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/auth-output-hygiene-adda

📝 Commits (1)

6440c56 Redact auth env identifiers in status and doctor

📊 Changes

5 files changed (+68 additions, -6 deletions)

View changed files

📝 internal/auth/doctor.go (+1 -5)
📝 internal/auth/doctor_test.go (+25 -0)
📝 internal/cli/auth/auth.go (+1 -1)
📝 internal/cli/cmdtest/auth_doctor_test.go (+35 -0)
📝 internal/cli/cmdtest/commands_test.go (+6 -0)

📄 Description

Summary

Redacts ASC_KEY_ID and ASC_ISSUER_ID values from auth status and auth doctor output, replacing them with presence-only messages (e.g., "is set" or "present").
Adds new regression tests to prevent reintroduction of credential identifier leakage in auth status and auth doctor diagnostics.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/527 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/auth-output-hygiene-adda` --- ### 📝 Commits (1) - [`6440c56`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6440c565d38e5ba564d7efc839e869df09469a83) Redact auth env identifiers in status and doctor ### 📊 Changes **5 files changed** (+68 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/doctor.go` (+1 -5) 📝 `internal/auth/doctor_test.go` (+25 -0) 📝 `internal/cli/auth/auth.go` (+1 -1) 📝 `internal/cli/cmdtest/auth_doctor_test.go` (+35 -0) 📝 `internal/cli/cmdtest/commands_test.go` (+6 -0) </details> ### 📄 Description ## Summary - Redacts `ASC_KEY_ID` and `ASC_ISSUER_ID` values from `auth status` and `auth doctor` output, replacing them with presence-only messages (e.g., "is set" or "present"). - Adds new regression tests to prevent reintroduction of credential identifier leakage in `auth status` and `auth doctor` diagnostics. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- <p><a href="https://cursor.com/background-agent?bcId=bc-645f417d-4d9c-45e3-bf6f-73239a7dca8f"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-645f417d-4d9c-45e3-bf6f-73239a7dca8f"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>