[PR #514] [CLOSED] Shots command issues #587

New issue

Closed

opened 2026-02-26 22:31:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/514
Author: @cursor[bot]
Created: 2/13/2026
Status: ❌ Closed

Base: feat/shots-capture-mvp ← Head: cursor/shots-command-issues-3d47

📝 Commits (1)

16d3eb9 Fix shots frame/review config metadata and cleanup bugs

📊 Changes

6 files changed (+285 additions, -12 deletions)

View changed files

📝 internal/cli/shots/shots_frame.go (+4 -1)
➕ internal/cli/shots/shots_frame_test.go (+20 -0)
📝 internal/screenshots/frame.go (+26 -8)
📝 internal/screenshots/frame_test.go (+151 -0)
📝 internal/screenshots/review.go (+27 -3)
📝 internal/screenshots/review_test.go (+57 -0)

📄 Description

Summary

Fixed an issue where shots frame with --config only would create hidden output files (e.g., .iphone-air.png) by ensuring a sensible default filename is used when no input path is provided.
Corrected FrameResult.Device to reflect the actual device specified in the Koubou config when running in config-driven mode, instead of the CLI default.
Enhanced raw screenshot matching in shots review to consider locale and device paths, preventing incorrect associations when multiple raw files share a base filename.
Implemented cleanup for temporary Koubou directories created by createDefaultKoubouConfig to prevent disk space accumulation.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/514 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/13/2026 **Status:** ❌ Closed **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/shots-command-issues-3d47` --- ### 📝 Commits (1) - [`16d3eb9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/16d3eb928a76f82a6f0e6c557e04f40e10626d0e) Fix shots frame/review config metadata and cleanup bugs ### 📊 Changes **6 files changed** (+285 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/shots/shots_frame.go` (+4 -1) ➕ `internal/cli/shots/shots_frame_test.go` (+20 -0) 📝 `internal/screenshots/frame.go` (+26 -8) 📝 `internal/screenshots/frame_test.go` (+151 -0) 📝 `internal/screenshots/review.go` (+27 -3) 📝 `internal/screenshots/review_test.go` (+57 -0) </details> ### 📄 Description ## Summary - Fixed an issue where `shots frame` with `--config` only would create hidden output files (e.g., `.iphone-air.png`) by ensuring a sensible default filename is used when no input path is provided. - Corrected `FrameResult.Device` to reflect the actual device specified in the Koubou config when running in config-driven mode, instead of the CLI default. - Enhanced raw screenshot matching in `shots review` to consider locale and device paths, preventing incorrect associations when multiple raw files share a base filename. - Implemented cleanup for temporary Koubou directories created by `createDefaultKoubouConfig` to prevent disk space accumulation. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>