[PR #513] [CLOSED] Shots bundle ID handling #586

New issue

Closed

opened 2026-02-26 22:31:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/513
Author: @cursor[bot]
Created: 2/13/2026
Status: ❌ Closed

Base: feat/shots-capture-mvp ← Head: cursor/shots-bundle-id-handling-9dd8

📝 Commits (1)

3b3e2a8 Fix shots bundle-id capture targeting and run override ordering

📊 Changes

5 files changed (+134 additions, -5 deletions)

View changed files

📝 internal/cli/cmdtest/shots_run_test.go (+46 -0)
📝 internal/cli/shots/shots_run.go (+1 -1)
📝 internal/screenshots/plan.go (+12 -3)
📝 internal/screenshots/provider_axe.go (+9 -1)
📝 internal/screenshots/provider_axe_test.go (+66 -0)

📄 Description

Summary

Fixed an issue where shots capture ignored the provided bundle ID, potentially capturing the wrong app's UI, by activating the specified app before taking the screenshot.
Corrected the order of operations in shots run to ensure --bundle-id overrides are applied before plan validation, allowing incomplete plans to be augmented at runtime.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/513 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/13/2026 **Status:** ❌ Closed **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/shots-bundle-id-handling-9dd8` --- ### 📝 Commits (1) - [`3b3e2a8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3b3e2a83c1a806e0c0ba87f65639110f93fef0fe) Fix shots bundle-id capture targeting and run override ordering ### 📊 Changes **5 files changed** (+134 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/shots_run_test.go` (+46 -0) 📝 `internal/cli/shots/shots_run.go` (+1 -1) 📝 `internal/screenshots/plan.go` (+12 -3) 📝 `internal/screenshots/provider_axe.go` (+9 -1) 📝 `internal/screenshots/provider_axe_test.go` (+66 -0) </details> ### 📄 Description ## Summary - Fixed an issue where `shots capture` ignored the provided bundle ID, potentially capturing the wrong app's UI, by activating the specified app before taking the screenshot. - Corrected the order of operations in `shots run` to ensure `--bundle-id` overrides are applied before plan validation, allowing incomplete plans to be augmented at runtime. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>