[PR #511] [CLOSED] Screenshot image output #585

New issue

Closed

opened 2026-02-26 22:31:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/511
Author: @cursor[bot]
Created: 2/13/2026
Status: ❌ Closed

Base: feat/shots-capture-mvp ← Head: cursor/screenshot-image-output-b6a1

📝 Commits (1)

615c04b Fix screenshot frame edge compositing and clean JSON command output

📊 Changes

4 files changed (+126 additions, -3 deletions)

View changed files

📝 internal/screenshots/frame.go (+30 -1)
📝 internal/screenshots/frame_test.go (+44 -0)
📝 internal/screenshots/run.go (+18 -2)
➕ internal/screenshots/run_test.go (+34 -0)

📄 Description

Summary

Fixed an issue where anti-aliased outer edges of device frames would appear with a dark fringe due to incorrect blending against a black base instead of white.
Addressed a potential edge case where cmd.CombinedOutput() could cause JSON parsing failures if external commands emitted anything to stderr, by switching to cmd.Output() for JSON-parsed output.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/511 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/13/2026 **Status:** ❌ Closed **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/screenshot-image-output-b6a1` --- ### 📝 Commits (1) - [`615c04b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/615c04b87e40765d06dcb7fdf1e9b3f30c579e5c) Fix screenshot frame edge compositing and clean JSON command output ### 📊 Changes **4 files changed** (+126 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/screenshots/frame.go` (+30 -1) 📝 `internal/screenshots/frame_test.go` (+44 -0) 📝 `internal/screenshots/run.go` (+18 -2) ➕ `internal/screenshots/run_test.go` (+34 -0) </details> ### 📄 Description ## Summary - Fixed an issue where anti-aliased outer edges of device frames would appear with a dark fringe due to incorrect blending against a black base instead of white. - Addressed a potential edge case where `cmd.CombinedOutput()` could cause JSON parsing failures if external commands emitted anything to stderr, by switching to `cmd.Output()` for JSON-parsed output. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>