[PR #512] [MERGED] Provider constant duplication #584

New issue

Closed

opened 2026-02-26 22:31:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/512
Author: @cursor[bot]
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @rudrankriyam

Base: feat/shots-capture-mvp ← Head: cursor/provider-constant-duplication-317d

📝 Commits (1)

b69c9b3 Use shared screenshots provider constant

📊 Changes

1 file changed (+3 additions, -7 deletions)

View changed files

📝 internal/cli/shots/shots_capture.go (+3 -7)

📄 Description

Summary

Replaced duplicated providerAXe constant with screenshots.ProviderAXe to prevent potential divergence and improve maintainability.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/512 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/provider-constant-duplication-317d` --- ### 📝 Commits (1) - [`b69c9b3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b69c9b3057038bd2d96f8445a050be426096c26a) Use shared screenshots provider constant ### 📊 Changes **1 file changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/shots/shots_capture.go` (+3 -7) </details> ### 📄 Description ## Summary - Replaced duplicated `providerAXe` constant with `screenshots.ProviderAXe` to prevent potential divergence and improve maintainability. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>