[PR #500] [CLOSED] Iphone 6.9 display mapping #574

New issue

Closed

opened 2026-02-26 22:31:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/500
Author: @cursor[bot]
Created: 2/11/2026
Status: ❌ Closed

Base: cursor/migrate-import-full-layout-b7cc ← Head: cursor/iphone-6-9-display-mapping-cc49

📝 Commits (1)

6f80a49 Fix iPhone 6.9 filename display hint

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 internal/cli/migrate/screenshots.go (+1 -1)
📝 internal/cli/migrate/screenshots_test.go (+14 -0)

📄 Description

Summary

Corrected the filename hint mapping for "iphone6.9" to "APP_IPHONE_69" instead of "APP_IPHONE_67" in inferDisplayTypeFromFilename to ensure screenshots are categorized correctly, and added a new test case.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/500 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/11/2026 **Status:** ❌ Closed **Base:** `cursor/migrate-import-full-layout-b7cc` ← **Head:** `cursor/iphone-6-9-display-mapping-cc49` --- ### 📝 Commits (1) - [`6f80a49`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6f80a49322ac02ab82395d6dce4a9270f1d44373) Fix iPhone 6.9 filename display hint ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/migrate/screenshots.go` (+1 -1) 📝 `internal/cli/migrate/screenshots_test.go` (+14 -0) </details> ### 📄 Description ## Summary - Corrected the filename hint mapping for `"iphone6.9"` to `"APP_IPHONE_69"` instead of `"APP_IPHONE_67"` in `inferDisplayTypeFromFilename` to ensure screenshots are categorized correctly, and added a new test case. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>