[PR #490] [MERGED] Screenshot size validation #565

New issue

Closed

opened 2026-02-26 22:31:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/490
Author: @rudrankriyam
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/screenshot-size-validation-bfbc

📝 Commits (3)

3b1dee6 Add screenshot sizes catalog and validation
c840bb2 fix: expand large iPhone screenshot compatibility
073bbc9 fix: align non-iOS screenshot dimensions with Apple specs

📊 Changes

10 files changed (+1209 additions, -38 deletions)

View changed files

📝 README.md (+4 -0)
📝 internal/asc/assets.go (+1 -37)
📝 internal/asc/assets_output.go (+13 -0)
📝 internal/asc/assets_upload.go (+31 -0)
📝 internal/asc/output_registry_init.go (+1 -0)
➕ internal/asc/screenshot_sizes.go (+237 -0)
➕ internal/asc/screenshot_sizes_test.go (+310 -0)
📝 internal/cli/assets/assets_screenshots.go (+71 -1)
➕ internal/cli/assets/assets_screenshots_test.go (+151 -0)
➕ internal/cli/cmdtest/assets_screenshots_sizes_test.go (+390 -0)

📄 Description

Summary

Implemented asc assets screenshots sizes command to list supported screenshot dimensions with optional display-type filtering and various output formats (JSON, table, markdown).
Added strict local validation for screenshot image dimensions during asc assets screenshots upload, ensuring images conform to the specified display type's requirements before any network requests are made. This provides immediate, actionable feedback to the user.
Introduced a schema drift test to automatically verify that the supported screenshot display types in the CLI's internal registry remain synchronized with the OpenAPI specification.
Updated README.md with examples for the new sizes command.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/490 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/screenshot-size-validation-bfbc` --- ### 📝 Commits (3) - [`3b1dee6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3b1dee6d4c5b5b17920a29e8a92d98d61466c70c) Add screenshot sizes catalog and validation - [`c840bb2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c840bb2b179f760547399169c1055182ec2c50ff) fix: expand large iPhone screenshot compatibility - [`073bbc9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/073bbc95d4242cf6c0a23e96b5c5792125bd0af5) fix: align non-iOS screenshot dimensions with Apple specs ### 📊 Changes **10 files changed** (+1209 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -0) 📝 `internal/asc/assets.go` (+1 -37) 📝 `internal/asc/assets_output.go` (+13 -0) 📝 `internal/asc/assets_upload.go` (+31 -0) 📝 `internal/asc/output_registry_init.go` (+1 -0) ➕ `internal/asc/screenshot_sizes.go` (+237 -0) ➕ `internal/asc/screenshot_sizes_test.go` (+310 -0) 📝 `internal/cli/assets/assets_screenshots.go` (+71 -1) ➕ `internal/cli/assets/assets_screenshots_test.go` (+151 -0) ➕ `internal/cli/cmdtest/assets_screenshots_sizes_test.go` (+390 -0) </details> ### 📄 Description ## Summary - Implemented `asc assets screenshots sizes` command to list supported screenshot dimensions with optional display-type filtering and various output formats (JSON, table, markdown). - Added strict local validation for screenshot image dimensions during `asc assets screenshots upload`, ensuring images conform to the specified display type's requirements *before* any network requests are made. This provides immediate, actionable feedback to the user. - Introduced a schema drift test to automatically verify that the supported screenshot display types in the CLI's internal registry remain synchronized with the OpenAPI specification. - Updated `README.md` with examples for the new `sizes` command. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- <p><a href="https://cursor.com/background-agent?bcId=bc-5c5bfa64-1e38-4601-b972-6cb7543feb93"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-5c5bfa64-1e38-4601-b972-6cb7543feb93"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>