[PR #488] [MERGED] Auth doctor migration hints #562

New issue

Closed

opened 2026-02-26 22:31:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/488
Author: @rudrankriyam
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/auth-doctor-migration-hints-eb8e

📝 Commits (2)

00f0e4f Add auth doctor migration hints
87906e9 Enhance auth doctor migration hint personalization.

📊 Changes

6 files changed (+1391 additions, -6 deletions)

View changed files

📝 README.md (+1 -1)
📝 internal/auth/doctor.go (+15 -4)
➕ internal/auth/doctor_migration.go (+697 -0)
📝 internal/auth/doctor_test.go (+368 -0)
📝 internal/cli/auth/auth.go (+80 -1)
➕ internal/cli/cmdtest/auth_doctor_test.go (+230 -0)

📄 Description

Summary

Extends asc auth doctor to detect fastlane configuration files (Appfile, Fastfile, Deliverfile, Gemfile/Gemfile.lock) and provide migration hints.
Suggests equivalent asc commands for common fastlane actions (e.g., auth setup, metadata sync, build lookup, testflight/app store publishing).
Ensures no sensitive information is leaked from detected files.
Updates asc auth doctor JSON and text output to include migration hints.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/488 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/auth-doctor-migration-hints-eb8e` --- ### 📝 Commits (2) - [`00f0e4f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/00f0e4f5fa3ae099c19cdc5f007a241a8b42c914) Add auth doctor migration hints - [`87906e9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/87906e9628391457b0ea4dfcc327c1754a57ff82) Enhance auth doctor migration hint personalization. ### 📊 Changes **6 files changed** (+1391 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `internal/auth/doctor.go` (+15 -4) ➕ `internal/auth/doctor_migration.go` (+697 -0) 📝 `internal/auth/doctor_test.go` (+368 -0) 📝 `internal/cli/auth/auth.go` (+80 -1) ➕ `internal/cli/cmdtest/auth_doctor_test.go` (+230 -0) </details> ### 📄 Description ## Summary - Extends `asc auth doctor` to detect fastlane configuration files (`Appfile`, `Fastfile`, `Deliverfile`, `Gemfile`/`Gemfile.lock`) and provide migration hints. - Suggests equivalent `asc` commands for common fastlane actions (e.g., auth setup, metadata sync, build lookup, testflight/app store publishing). - Ensures no sensitive information is leaked from detected files. - Updates `asc auth doctor` JSON and text output to include migration hints. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-b6bb9888-8687-45d4-ba2f-cb33668b48e2"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-b6bb9888-8687-45d4-ba2f-cb33668b48e2"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>