[PR #481] [MERGED] chore(wall): improve contribution flow and platform handling #561

New issue

Closed

opened 2026-02-26 22:31:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/481
Author: @rudrankriyam
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/wall-contrib-template-platforms-clean

📝 Commits (2)

9457c1b chore(wall): improve contribution flow and platform handling
844d0c8 refactor(wall): use a single generated wall output

📊 Changes

9 files changed (+453 additions, -85 deletions)

View changed files

➕ .github/PULL_REQUEST_TEMPLATE.md (+30 -0)
📝 .github/workflows/main-branch.yml (+1 -1)
📝 .github/workflows/pr-checks.yml (+1 -1)
📝 CONTRIBUTING.md (+14 -9)
📝 README.md (+23 -0)
➖ docs/generated/app-wall.md (+0 -12)
📝 internal/wallgen/wallgen.go (+17 -38)
📝 internal/wallgen/wallgen_test.go (+367 -23)
📝 tools/update-wall-of-apps/main.go (+0 -1)

📄 Description

Summary

Add a pull request template with a Wall of Apps checklist and copy/paste JSON entry template.
Update README.md and CONTRIBUTING.md to make docs/wall-of-apps.json the explicit source of truth and require regenerating Wall files.
Relax wall platform validation to allow free-form labels while canonicalizing common Apple aliases (iOS, macOS, watchOS, tvOS, visionOS).

Test plan

go test ./internal/wallgen
make update-wall-of-apps
Pre-commit checks passed (make format, make lint, short test suite)
CI checks pass

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/481 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/wall-contrib-template-platforms-clean` --- ### 📝 Commits (2) - [`9457c1b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9457c1b93754b7e7ef4a89a05992e52d0cfb6264) chore(wall): improve contribution flow and platform handling - [`844d0c8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/844d0c8912837717c6309afadf48f01ed63a9129) refactor(wall): use a single generated wall output ### 📊 Changes **9 files changed** (+453 additions, -85 deletions) <details> <summary>View changed files</summary> ➕ `.github/PULL_REQUEST_TEMPLATE.md` (+30 -0) 📝 `.github/workflows/main-branch.yml` (+1 -1) 📝 `.github/workflows/pr-checks.yml` (+1 -1) 📝 `CONTRIBUTING.md` (+14 -9) 📝 `README.md` (+23 -0) ➖ `docs/generated/app-wall.md` (+0 -12) 📝 `internal/wallgen/wallgen.go` (+17 -38) 📝 `internal/wallgen/wallgen_test.go` (+367 -23) 📝 `tools/update-wall-of-apps/main.go` (+0 -1) </details> ### 📄 Description ## Summary - Add a pull request template with a Wall of Apps checklist and copy/paste JSON entry template. - Update `README.md` and `CONTRIBUTING.md` to make `docs/wall-of-apps.json` the explicit source of truth and require regenerating Wall files. - Relax wall platform validation to allow free-form labels while canonicalizing common Apple aliases (`iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`). ## Test plan - [x] `go test ./internal/wallgen` - [x] `make update-wall-of-apps` - [x] Pre-commit checks passed (`make format`, `make lint`, short test suite) - [ ] CI checks pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>