[PR #482] [MERGED] chore: upgrade project to Go 1.26 #560

New issue

Closed

opened 2026-02-26 22:31:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/482
Author: @rudrankriyam
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/go1.26-upgrade

📝 Commits (7)

b733c70 chore: upgrade project to Go 1.26
0a6b7a4 refactor: adopt errors.AsType in runtime paths
3b8662f test: complete Go 1.26 cleanup and regression coverage
8da6249 refactor: simplify pricing worker bounds
78b0ebf test: extend malformed URL regression coverage
16abd99 test(auth): cover malformed host URL parsing
e30b571 merge: sync latest main into go1.26 branch

📊 Changes

119 files changed (+569 additions, -531 deletions)

View changed files

📝 .github/workflows/integration.yml (+1 -1)
📝 .github/workflows/main-branch.yml (+1 -1)
📝 .github/workflows/pr-checks.yml (+1 -1)
📝 .github/workflows/release.yml (+1 -1)
📝 CONTRIBUTING.md (+1 -1)
📝 README.md (+1 -1)
📝 cmd/exit_codes.go (+3 -10)
📝 cmd/run.go (+3 -4)
📝 docs/GO_STANDARDS.md (+12 -4)
📝 go.mod (+1 -1)
📝 internal/asc/age_rating.go (+1 -1)
📝 internal/asc/alternative_distribution.go (+2 -2)
📝 internal/asc/analytics.go (+3 -3)
📝 internal/asc/analytics_output.go (+1 -1)
📝 internal/asc/assets.go (+4 -12)
📝 internal/asc/beta_license_agreements.go (+6 -6)
📝 internal/asc/beta_recruitment.go (+1 -1)
📝 internal/asc/build_beta_notifications.go (+1 -1)
📝 internal/asc/categories.go (+4 -4)
📝 internal/asc/client_app_clips.go (+3 -3)

...and 80 more files

📄 Description

Summary

bump project Go version from 1.24 to 1.26 in go.mod, docs, and GitHub Actions workflows
run go fix ./... under Go 1.26 and keep resulting source modernizations across CLI and ASC packages
keep the tree green by resolving follow-up lint fallout and re-running formatting/lint/tests

Test plan

go fix ./...
make tools
make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/482 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/go1.26-upgrade` --- ### 📝 Commits (7) - [`b733c70`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b733c709a26d4a329ab044203804ecf1d40a324d) chore: upgrade project to Go 1.26 - [`0a6b7a4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0a6b7a40c040275918a0022571f7f85ec3121559) refactor: adopt errors.AsType in runtime paths - [`3b8662f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3b8662f508892ae3bd6f6adef0cdad59cc6e4a34) test: complete Go 1.26 cleanup and regression coverage - [`8da6249`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8da624930735e6d6cf196be48fb7f7ff832a456f) refactor: simplify pricing worker bounds - [`78b0ebf`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/78b0ebfc4796e87c2f79020f40235eec1dc2ad62) test: extend malformed URL regression coverage - [`16abd99`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/16abd99849756fa12b7d00000eeb3a2ef09becd4) test(auth): cover malformed host URL parsing - [`e30b571`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e30b5715d053f1e36bab08928863d16c1aefaa4f) merge: sync latest main into go1.26 branch ### 📊 Changes **119 files changed** (+569 additions, -531 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/integration.yml` (+1 -1) 📝 `.github/workflows/main-branch.yml` (+1 -1) 📝 `.github/workflows/pr-checks.yml` (+1 -1) 📝 `.github/workflows/release.yml` (+1 -1) 📝 `CONTRIBUTING.md` (+1 -1) 📝 `README.md` (+1 -1) 📝 `cmd/exit_codes.go` (+3 -10) 📝 `cmd/run.go` (+3 -4) 📝 `docs/GO_STANDARDS.md` (+12 -4) 📝 `go.mod` (+1 -1) 📝 `internal/asc/age_rating.go` (+1 -1) 📝 `internal/asc/alternative_distribution.go` (+2 -2) 📝 `internal/asc/analytics.go` (+3 -3) 📝 `internal/asc/analytics_output.go` (+1 -1) 📝 `internal/asc/assets.go` (+4 -12) 📝 `internal/asc/beta_license_agreements.go` (+6 -6) 📝 `internal/asc/beta_recruitment.go` (+1 -1) 📝 `internal/asc/build_beta_notifications.go` (+1 -1) 📝 `internal/asc/categories.go` (+4 -4) 📝 `internal/asc/client_app_clips.go` (+3 -3) _...and 80 more files_ </details> ### 📄 Description ## Summary - bump project Go version from 1.24 to 1.26 in `go.mod`, docs, and GitHub Actions workflows - run `go fix ./...` under Go 1.26 and keep resulting source modernizations across CLI and ASC packages - keep the tree green by resolving follow-up lint fallout and re-running formatting/lint/tests ## Test plan - [x] `go fix ./...` - [x] `make tools` - [x] `make format` - [x] `make lint` - [x] `make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>