[PR #459] [MERGED] Exit code and report flag #542

Closed
opened 2026-02-26 22:31:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/459
Author: @cursor[bot]
Created: 2/9/2026
Status: Merged
Merged: 2/9/2026
Merged by: @rudrankriyam

Base: ci-exit-codesHead: cursor/exit-code-and-report-flag-d34d


📝 Commits (1)

  • 4f23562 fix: add ErrConflict sentinel check in exit code mapper and validate --report-file without --report

📊 Changes

4 files changed (+32 additions, -0 deletions)

View changed files

📝 cmd/exit_codes.go (+3 -0)
📝 cmd/exit_codes_test.go (+5 -0)
📝 internal/cli/cmdtest/exit_codes_test.go (+21 -0)
📝 internal/cli/shared/ci_flags.go (+3 -0)

📄 Description

Fixes two bugs: ErrConflict now maps to the correct exit code, and --report-file is no longer silently ignored without --report.



🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/459 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `ci-exit-codes` ← **Head:** `cursor/exit-code-and-report-flag-d34d` --- ### 📝 Commits (1) - [`4f23562`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4f2356266ec3cbd533d945e988e3e904379c7ec5) fix: add ErrConflict sentinel check in exit code mapper and validate --report-file without --report ### 📊 Changes **4 files changed** (+32 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/exit_codes.go` (+3 -0) 📝 `cmd/exit_codes_test.go` (+5 -0) 📝 `internal/cli/cmdtest/exit_codes_test.go` (+21 -0) 📝 `internal/cli/shared/ci_flags.go` (+3 -0) </details> ### 📄 Description Fixes two bugs: `ErrConflict` now maps to the correct exit code, and `--report-file` is no longer silently ignored without `--report`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 22:31:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#542
No description provided.